chor(ci): fix app-version script

Notalib · May 14, 2024 · f2c0a75 · f2c0a75
1 parent 1db8922
commit f2c0a75
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/chart.yml b/.github/workflows/chart.yml
@@ -19,8 +19,8 @@ jobs:
         run: |
           git config user.name "nota-ci"
           git config user.email "[email protected]"
-          # git add ci/helm-chart/Chart.yaml
-          git commit -m "chor(ci): update Chart version" || echo "No changes to commit"
+          git add ci/helm-chart/Chart.yaml
+          git commit -m "chor(ci): update Chart version" || echo "Nothing to commit"
           git push origin ${{ github.ref_name }}
       - name: Publish Helm chart
         uses: stefanprodan/[email protected]

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -32,7 +32,7 @@ jobs:
       - name: Get version
         id: version
         run: |
-          APP_VERSION=$(grep "Software_Version = "$1"" $GIT_ROOT/api/common_server.go | awk '{print $3}' | sed 's/"//g')
+          APP_VERSION=$(grep "Software_Version = " api/common_server.go | awk '{print $3}' | sed 's/"//g')
           echo "APP_VERSION=$APP_VERSION" >> $GITHUB_ENV
 
       # Build lcpserver

diff --git a/ci/update_chart_version.sh b/ci/update_chart_version.sh
@@ -5,7 +5,7 @@ set -e
 GIT_ROOT="$(git rev-parse --show-toplevel)"
 
 # Retrieve the version from api/common_server.go
-APP_VERSION=$(grep "Software_Version = "$1"" $GIT_ROOT/api/common_server.go | awk '{print $3}' | sed 's/"//g')
+APP_VERSION=$(grep "Software_Version = " $GIT_ROOT/api/common_server.go | awk '{print $3}' | sed 's/"//g')
 
 if [ -z "$APP_VERSION" ]; then
   echo "Error: Could not find version in api/common_server.go"