Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember which commits have been processed #39

Open
Notgnoshi opened this issue Apr 12, 2024 · 0 comments
Open

Remember which commits have been processed #39

Notgnoshi opened this issue Apr 12, 2024 · 0 comments
Milestone
11 - Persistence ...

Comments

@Notgnoshi
Copy link
Owner

Processing a large repository like Linux or Git takes longer than I want. So avoid doing the same work over and over.

  • Remember what commits have been processed
    • Don't save every commit in a HashSet; just save the last commit processed for the given reference.
    • For each checkpoint, save the rules that were applied to all of the commits up to that point
    • When new rules are added, no need to re-process the same commits with existing rules
    • After fetching, no need to re-process all of the same commits, only the new ones
  • Remember what rules were applied to each of the checkpoints
@Notgnoshi Notgnoshi added this to the 11 - Persistence layer milestone Apr 12, 2024
@Notgnoshi Notgnoshi mentioned this issue Aug 19, 2024
Merged
Notgnoshi added a commit that referenced this issue Aug 19, 2024
@Notgnoshi
Improve fetch-all subcommand (#52)
696a7ed 
Closes #50
Closes #51

What needs to be done before 0.1.0 release:

* JSON achievement stdout output - #40
* At least 3 meaningful achievements
  * One of which needs to store state across multiple visited commits
  * See: https://github.com/Notgnoshi/herostratus/milestone/7 for ideas
* Optionally: Commit iterator caching - #7 and #39
@Notgnoshi Notgnoshi mentioned this issue Oct 20, 2024
Merged
Notgnoshi added a commit that referenced this issue Oct 20, 2024
@Notgnoshi
Release Herostratus 0.1.0 (#57)
3e6eafc 
Includes a few internal cleanups. This PR represents the most bare
minimal working "product".

Before it's usable, the following need to be done:

1. Allow excluding commits (#47)
2. Allow customizing which rules are run (#53)
3. A "useful" output format (#40)
4. Remember what commits have already been processed (#39)
   so that repeated `herostratus fetch-all && herostratus check-all`
   invocations only give new achievements
5. More achievements! (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11 - Persistence layer
Development

No branches or pull requests
1 participant
@Notgnoshi