Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the import fail? #19

Open
maomao123-pcu opened this issue Dec 8, 2023 · 14 comments
Open

Why does the import fail? #19

maomao123-pcu opened this issue Dec 8, 2023 · 14 comments

Comments

@maomao123-pcu
Copy link

maomao123-pcu commented Dec 8, 2023

I have updated
截屏2023-12-08 20 20 49

@Nourepide
Copy link
Owner

Apparently Allor has not been fully installed, you need to run install.sh

When you download from a direct link from GitHub this directory is not the default repository.

Also rembg and other dependencies are installed while running install.sh

About install.sh.

@Nourepide
Copy link
Owner

Wait... are you using windows-portable ComfyUI with macOS?

I didn't anticipate these use cases when I made install.sh 😅

@maomao123-pcu
Copy link
Author

等等...您是否在 macOS 上使用 Windows 便携式 ComfyUI?

当我制作 install.sh 时,我没有预料到这些用例 😅

截屏2023-12-08 21 55 20 it stopped on MACos

@Nourepide
Copy link
Owner

I'm finally home and can help you.

The ASCI-escape color code is not working

Not good.

Venv found

Very good

Dependency installation freezes

Very not good

Open install.sh with any text editor and change text here with

pip install -r requirements.txt

I mean just delete the arguments and run again.

@maomao123-pcu
Copy link
Author

I'm finally home and can help you.

The ASCI-escape color code is not working

Not good.

Venv found

Very good

Dependency installation freezes

Very not good

Open install.sh with any text editor and change text here with

pip install -r requirements.txt

I mean just delete the arguments and run again.

1
My steps are
cd /Users/wangshuya/Documents/ComfyUI_windows_portable/Comfyui/custom_nodes/ComfyUI-Allor
bash install.sh
cd /Users/wangshuya/Documents/ComfyUI_windows_portable/Comfyui
./venv/bin/python main.py
Is still failed,I have no coding background so these steps are difficult for me

@maomao123-pcu
Copy link
Author

I found the reason. The UCL address and downloaded zip file are inconsistent with your complete code number. causing me to use incomplete code。Now I can use it, thanks for your help

@FrankAIfuture
Copy link

I encountered the same issue, but I'm using Windows 11. When I try to install using the manager, I receive an "install failed" message. After restarting comfyUI, an "import fail" message appears.
microsoft-screensketch_8wekyb3d8bbwe-app_42609_0

@anor168
Copy link

anor168 commented Dec 14, 2023

请问我缺失Allor这个插件,但安装时提示要在设置中禁用覆盖功能,但找不到在哪设置

@Nourepide
Copy link
Owner

请问我缺失Allor这个插件,但安装时提示要在设置中禁用覆盖功能,但找不到在哪设置

No need to disable override because it's been disabled by default for like 5 months now.

I encountered the same issue, but I'm using Windows 11. When I try to install using the manager, I receive an "install failed" message. After restarting comfyUI, an "import fail" message appears.

Does the error occur when you try to install Allor when you already had it before? It's just that error 128 only occurs in this case.

@Nourepide
Copy link
Owner

Nourepide commented Dec 15, 2023

Guys, I think I found the source of the problem.

When I tried to manually install Allor on my Windows machine, I got a warning on download that the Git LFS quota was exhausted and the download was cancelled.

This is just ridiculous. GitHub allows unlimited downloads of regular files, but it doesn't allow optimised files that are listed in Git LFS and that are for downloading and not for overflowing disk space.

I've already removed all Git LFS files from Allor and moved them to a separate repository.

At least this problem should now be resolved.

I'm sorry about that.

@FrankAIfuture
Copy link

Thanks for your help!

After using Comfyui Manager to "Update All" and then reinstalling Allor, it worked!

However, I'm still unsure about what went wrong before.

@Nourepide
Copy link
Owner

I suspect it was both Git LFS and the fact that I used force push which changed the commit history.

Or rather, one thing came out of the other.

I thought it would be nice if users downloaded a few kilobytes of the repository rather than 40mb. So the images were removed from the repository. But for Git it's not enough to just delete something, it stays in the history and keeps weight. So I had to delete the commits that contained these images, which changed the hashes of all the commits in the chain above.

Even though I had prepared for this in advance and even added the ability to update via hard mode I decided that it was better for users not to repeat this experience and decided to use Git LFS which doesn't save files in the history.

However, that doesn't change the fact that I'm not really sure what the problem was or how many users have experienced it.

@richkel
Copy link

richkel commented Feb 16, 2024

im having this problem with the import fail. i have tried running the install even though I pulled it from the comfy manager link,

@HydraBucket
Copy link

I am having the same error... advice would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants