Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cindex equal 0 #61

Closed
tcoroller opened this issue Oct 24, 2024 · 4 comments
Closed

cindex equal 0 #61

tcoroller opened this issue Oct 24, 2024 · 4 comments
Assignees
@tcoroller
Labels
bug 🐛 Something isn't working
Milestone
backlog

Comments

@tcoroller
Copy link
Collaborator

File "/home/corolth1/torchsurv/src/torchsurv/metrics/cindex.py", line 568, in _p_value_noether
raise ValueError(
ValueError: The standard error of concordance index must be a positive value.
@tcoroller tcoroller linked a pull request Oct 24, 2024 that will close this issue
issue with noether p-value #62
Closed
@melodiemonod
Copy link
Collaborator

Hi @tcoroller ,

I don't think the edits proposed are correct because it would lead to a division by 0 (

torchsurv/src/torchsurv/metrics/cindex.py

Line 590 in 57845ed

(self.cindex - null_value) / cindex_se
).

The se should not be 0. Do you want to give me a reproducible code so I can check the error you got?

@tcoroller
Copy link
Collaborator Author

Sounds good, let me try to do a reproducible example

@tcoroller
Copy link
Collaborator Author

Unless we can do something like:
(self.cindex - null_value) / (cindex_se + eps) ?

@melodiemonod
Copy link
Collaborator

I mean intuitively the c-index standard error should never be 0. I'm curious to know what can can lead to this!

@tcoroller tcoroller added the bug 🐛 Something isn't working label Dec 5, 2024
@tcoroller tcoroller added this to the backlog milestone Dec 12, 2024
@tcoroller tcoroller self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcoroller tcoroller

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

issue with noether p-value Novartis/torchsurv
2 participants
@tcoroller @melodiemonod