Delete Key does not prompt a "Remove Torrent" confirmation, even with the option checked in. like in old issue #2596

[FunThomas76]

Please complete the following tasks.

• Web browser cache cleared
• Link provided to install script if applicable
• Not using broken rtinst install script
• Web browser, ruTorrent, PHP and OS version provided

Tell us about your environment

windows 10 Firefox latest, rutorrent 5.1.5, rtorrent 0.9.8 (on seedbox seedhost.eu)
behaves like in issue #2596

Tell us how you installed ruTorrent

seedhost.eu environment

Describe the bug

behaves like in issue #2596

Steps to reproduce

check settings to ask for confirmation when delete

mark a torrent press del -> no confirmation dialog appears

Expected behavior

mark a torrent press del -> a confirmation dialog appears

Additional context

No response

[ranirahn]

I looked at the v5.1.5 code and it has all the https://github.com/Novik/ruTorrent/pull/2724/files red rows in there. Like it have never been fixed before. Someone can copy paste and fix the code again, but whats the point if next version its gone again? 🤦

[jevenski]

This had been fixed once but was then reverted because of another regression. The effective fix was later patched onto the v5.2 develop branch and backported to the v4.3 branch. The master branch just somehow got away with it. Anyway, cherry-pick this patch onto the master branch and it should be fine: 3f33192