Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --include-qt-plugins options #15

Open
JaegerStephan opened this issue Mar 21, 2023 · 6 comments
Open

Add --include-qt-plugins options #15

JaegerStephan opened this issue Mar 21, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@JaegerStephan
Copy link
Contributor

Nuitka has the option to include qt plugins with the option --include-qt-plugins followed by a list of plugins.
How can this be integrated into the github action because there is no option for qt?

@kayhayen
Copy link
Member

That is right, and actually it's an extremely import one. Please allow for a bit of time, because I want to use this, to somehow generate this from Nuitka's full set of options, rather than manually aligning them.

@kayhayen kayhayen added the enhancement New feature or request label Mar 21, 2023
@kayhayen kayhayen self-assigned this Mar 21, 2023
@JaegerStephan
Copy link
Contributor Author

JaegerStephan commented Mar 21, 2023

Hey @kayhayen!
Sounds good. Can you roughly estimate when it will be available?
Great job, by the way! 🙂

@kayhayen
Copy link
Member

I estimate that it will not be available before its ready. That will be sooner if you help. Otherwise I am not making promises on time scales outside of Nuitka commercial, and not even there really.

@JaegerStephan
Copy link
Contributor Author

Can you please let me know how I could help. do you have a suggestion what to do next? Is it restricted to Nuitka-Action or are changes for Nuitka necessary as well?

@kayhayen
Copy link
Member

If you look at the Nuitka action code, it will be actually trivial. The thing is, right now, powershell and bash code duplicate for Windows and macOS/Linux to command building code. I would love to see that unified. In fact, I will only do it when I do that first. But I will merge a PR that does add it with both syntaxes. Bonus points for unifying it though. Windows on GitHub can just use bash too. No point in this being duplicated because of shell syntax.

@kayhayen kayhayen changed the title How to --include-qt-plugins Add --include-qt-plugins options Mar 28, 2023
@kayhayen
Copy link
Member

With the 1.7 release, this will be working, however, for 1.8, there is actually a change, where sensible is a default now, and doesn't have to be provided (again) anymore, and to subtract from things, you specify the --noinclude-qt-plugins option instead. We need to add that to GitHub actions once 1.8 is released, which however is still a bit of. Obviously only a clone of your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants