Skip to content

Commit

Permalink
Fixed major bug, Fixed program breaking after one exception thrown
Browse files Browse the repository at this point in the history
  • Loading branch information
Numzskull committed Nov 15, 2021
1 parent 3c9484c commit 8d087ac
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 20 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>dev.vaziak.mavendd</groupId>
<artifactId>MavenDependencyDownloader</artifactId>
<version>1.0.1</version>
<version>1.0.2</version>

<properties>
<maven.compiler.source>8</maven.compiler.source>
Expand Down

This file was deleted.

2 changes: 1 addition & 1 deletion src/main/java/dev/vaziak/mavendd/MavenDownloader.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void download() {
}).findFirst().orElse(null);

if (repository == null) {
throw new DependencyNotFoundException(dependency.getGroupId() + ":" + dependency.getArtifactId() + ":" + dependency.getVersion());
return;
}

try {
Expand Down
31 changes: 20 additions & 11 deletions src/main/java/dev/vaziak/mavendd/XmlParser.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,31 @@ public ParsedPom parseXml(File pomFile) throws IOException, SAXException, Parser
NodeList dependencyNodes = document.getDocumentElement().getElementsByTagName("dependencies");

if (repositoryNodes != null) {
for (int i = 0; i < repositoryNodes.getLength(); i++) {
Element repositoryElement = (Element) repositoryNodes.item(i);
String url = repositoryElement.getElementsByTagName("url").item(0).getTextContent();
Element repositoryElement = (Element) repositoryNodes.item(0);

parsedPom.addRepository(new ParsedPom.Repository(url));
if (repositoryElement != null) {
NodeList urlList = repositoryElement.getElementsByTagName("url");

for (int i = 0; i < urlList.getLength(); i++) {
parsedPom.addRepository(new ParsedPom.Repository(urlList.item(i).getTextContent()));
}
}
}

if (dependencyNodes != null) {
for (int i = 0; i < dependencyNodes.getLength(); i++) {
Element dependencyElement = (Element) dependencyNodes.item(i);
String groupId = dependencyElement.getElementsByTagName("groupId").item(0).getTextContent();
String artifactId = dependencyElement.getElementsByTagName("artifactId").item(0).getTextContent();
String version = dependencyElement.getElementsByTagName("version").item(0).getTextContent();

parsedPom.addDependency(new ParsedPom.Dependency(groupId, artifactId, version));
Element dependencyElement = (Element) dependencyNodes.item(0);
if (dependencyElement != null) {
NodeList groupIdList = dependencyElement.getElementsByTagName("groupId");
NodeList artifactIdList = dependencyElement.getElementsByTagName("artifactId");
NodeList versionList = dependencyElement.getElementsByTagName("version");

for (int i = 0; i < groupIdList.getLength(); i++) {
parsedPom.addDependency(new ParsedPom.Dependency(
groupIdList.item(i).getTextContent(),
artifactIdList.item(i).getTextContent(),
versionList.item(i).getTextContent()
));
}
}
}

Expand Down

0 comments on commit 8d087ac

Please sign in to comment.