Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 实体高亮性能开销 #13

Open
1 task done
hexadecimal233 opened this issue Jul 16, 2023 · 1 comment
Open
1 task done

[Bug] 实体高亮性能开销 #13

hexadecimal233 opened this issue Jul 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@hexadecimal233
Copy link

hexadecimal233 commented Jul 16, 2023

Minecraft Version

1.20.1

OMMC Version

latest

Description

使用sparkc命令记录客户端性能状况,发现实体高亮不断获取实体本地化名:
String entityName = this.getType().getDescription().getString();
导致帧数大幅度下降(300->220)
是否可以考虑禁用实体名过滤功能呢,实体id一查就是(

更新:还发现有两处调用getDescription的,建议一起改掉

To Reproduce

使用sparkc命令记录客户端性能状况,发现实体高亮不断获取实体本地化名,导致帧数大幅度下降

Expected behavior

No response

Log

No response

Latest CI build tested

  • I confirm that this problem still exists with the latest CI build.
@hexadecimal233 hexadecimal233 added bug Something isn't working pending Awaiting response from developer labels Jul 16, 2023
@Hendrix-Shen
Copy link
Member

这个操作是 plusls 希望能支持输入本地化名称/不完全的名称来替代实体标识符全称的,可以考虑添加一个开关禁用这个特性。

@Hendrix-Shen Hendrix-Shen removed the pending Awaiting response from developer label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants