From 88c1e4ada1ff9159621243c01e79cbf08d42fde0 Mon Sep 17 00:00:00 2001
From: Murtuza Saleh <m.saleh.serpentcs@gmail.com>
Date: Tue, 13 Feb 2024 15:34:35 +0530
Subject: [PATCH] [MIG] base_phone_popup

---
 base_phone_popup/models/phone_common.py |  6 ++--
 base_phone_popup/views/res_users.xml    | 39 -------------------------
 2 files changed, 2 insertions(+), 43 deletions(-)
 delete mode 100644 base_phone_popup/views/res_users.xml

diff --git a/base_phone_popup/models/phone_common.py b/base_phone_popup/models/phone_common.py
index 80a36d754..1413cdb4e 100644
--- a/base_phone_popup/models/phone_common.py
+++ b/base_phone_popup/models/phone_common.py
@@ -46,7 +46,7 @@ def incall_notify_by_login(self, number, login_list):
         res = self.get_record_from_phone_number(number)
         users = self.env["res.users"].search([("login", "in", login_list)])
         logger.info(
-            "Notify incoming call from number %s to user IDs %s" % (number, users.ids)
+            f"Notify incoming call from number {number} to user IDs {users.ids}"
         )
         action = self._prepare_incall_pop_action(res, number)
         action = clean_action(action)
@@ -62,9 +62,7 @@ def incall_notify_by_login(self, number, login_list):
                 }
 
                 self.sudo().env["bus.bus"].sendone(channel, bus_message)
-                logger.debug(
-                    "This action has been sent to user ID %d: %s" % (user.id, action)
-                )
+                logger.debug(f"This action has been sent to user ID {user.id} {action}")
         if res:
             callerid = res[2]
         else:
diff --git a/base_phone_popup/views/res_users.xml b/base_phone_popup/views/res_users.xml
deleted file mode 100644
index df121b3df..000000000
--- a/base_phone_popup/views/res_users.xml
+++ /dev/null
@@ -1,39 +0,0 @@
-<?xml version="1.0" encoding="utf-8" ?>
-<!--
-  Copyright 2014-2018 Akretion France
-  @author: Alexis de Lattre <alexis.delattre@akretion.com>
-  License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
--->
-<odoo>
-
-
-<record id="view_users_form" model="ir.ui.view">
-    <field name="name">base_phone_popup.res.users.form</field>
-    <field name="model">res.users</field>
-    <field name="inherit_id" ref="base_phone.view_users_form" />
-    <field name="arch" type="xml">
-        <page name="phone" position="attributes">
-            <attribute name="invisible">0</attribute>
-        </page>
-        <group name="phone-preferences" position="inside">
-            <field name="context_incall_popup" />
-        </group>
-    </field>
-</record>
-
-<record id="view_users_form_simple_modif" model="ir.ui.view">
-    <field name="name">base_phone_popup.users.preferences.view</field>
-    <field name="model">res.users</field>
-    <field name="inherit_id" ref="base_phone.view_users_form_simple_modif" />
-    <field name="arch" type="xml">
-        <group name="phone" position="inside">
-            <field name="context_incall_popup" readonly="0" />
-        </group>
-        <group name="phone" position="attributes">
-            <attribute name="invisible">0</attribute>
-        </group>
-    </field>
-</record>
-
-
-</odoo>