[MIG] sms_twilio: Migration to 16.0

OCA · Jun 24, 2024 · da50b5b · da50b5b
1 parent 1131d01
commit da50b5b
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 13 deletions.
diff --git a/requirements.txt b/requirements.txt
@@ -1,3 +1,4 @@
 # generated from manifests external_dependencies
 phonenumbers
 requests
+twilio
diff --git a/sms_twilio/README.rst b/sms_twilio/README.rst
@@ -7,7 +7,7 @@ SMS Twilio
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:fd33cd14c1faf25aa72cb5b0357c5c6c7b6a1e843ca3238491051206e7215272
+   !! source digest: sha256:239b7212f3565c6315fe3c0326c1f5317f7a10d29dfa1712691d64284a7f1503
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

diff --git a/sms_twilio/__manifest__.py b/sms_twilio/__manifest__.py
@@ -4,15 +4,15 @@
 {
     "name": "SMS Twilio",
     "summary": "Send sms using Twilio API",
-    "version": "14.0.1.0.0",
+    "version": "16.0.1.0.0",
     "category": "SMS",
     "website": "https://github.com/OCA/connector-telephony",
     "author": "Akretion, Odoo Community Association (OCA)",
     "maintainers": ["mariadforgeflow"],
     "license": "AGPL-3",
     "application": False,
     "installable": True,
-    "external_dependencies": {"python": [], "bin": []},
+    "external_dependencies": {"python": ["twilio"], "bin": []},
     "depends": ["base_phone", "sms", "iap_alternative_provider"],
     "data": [
         "views/iap_account_view.xml",

diff --git a/sms_twilio/models/iap_account.py b/sms_twilio/models/iap_account.py
@@ -41,7 +41,7 @@ class IapAccount(models.Model):
     twilio_test_account_sid = fields.Char(string="Twilio TEST Account SID")
     twilio_test_auth_token = fields.Char(string="Twilio TEST Auth Token")
     twilio_account_sid = fields.Char(string="Twilio Account SID")
-    twilio_auth_token = fields.Char(string="Twilio Auth Token")
+    twilio_auth_token = fields.Char()
     twilio_number_id = fields.Many2one("twilio.phone.number", string="Twilio Number")
 
     twilio_balance_account = fields.Char(

diff --git a/sms_twilio/models/sms_api.py b/sms_twilio/models/sms_api.py
@@ -37,7 +37,7 @@ def _send_sms_with_twilio(self, number, message, sms_id):
             client.messages.create(to=number, from_=from_number, body=message)
         except TwilioRestException as e:
             self.env["sms.sms"].browse(sms_id).error_detail = e.msg
-            raise UserError(e.msg)
+            raise UserError(e.msg) from e
         return "success"
 
     @api.model

diff --git a/sms_twilio/models/twilio_numbers.py b/sms_twilio/models/twilio_numbers.py
@@ -10,7 +10,7 @@ class TwilioPhoneNumber(models.Model):
     _description = "Twilio Phone Number"
 
     name = fields.Char(string="Friendly Name")
-    phone_number = fields.Char(string="Phone Number")
+    phone_number = fields.Char()
     has_sms_enabled = fields.Boolean(string="SMS Enabled")
     sid = fields.Char(string="SID")
 

diff --git a/sms_twilio/static/description/index.html b/sms_twilio/static/description/index.html
@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
@@ -9,10 +8,11 @@
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
+:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
+Despite the name, some widely supported CSS2 features are used.
 
 See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
@@ -275,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: grey; } /* line numbers */
+pre.code .ln { color: gray; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic {
+span.problematic, pre.problematic {
   color: red }
 
 span.section-subtitle {
@@ -367,7 +367,7 @@ <h1 class="title">SMS Twilio</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:fd33cd14c1faf25aa72cb5b0357c5c6c7b6a1e843ca3238491051206e7215272
+!! source digest: sha256:239b7212f3565c6315fe3c0326c1f5317f7a10d29dfa1712691d64284a7f1503
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/connector-telephony/tree/16.0/sms_twilio"><img alt="OCA/connector-telephony" src="https://img.shields.io/badge/github-OCA%2Fconnector--telephony-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/connector-telephony-16-0/connector-telephony-16-0-sms_twilio"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/connector-telephony&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Implementation of <strong>Twilio API</strong> for sending sms.
@@ -420,7 +420,9 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <div class="section" id="maintainers">
 <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<a class="reference external image-reference" href="https://odoo-community.org">
+<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
+</a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>

diff --git a/sms_twilio/views/sms_sms_view.xml b/sms_twilio/views/sms_sms_view.xml
@@ -5,7 +5,7 @@
         <field name="model">sms.sms</field>
         <field name="inherit_id" ref="sms.sms_tsms_view_form" />
         <field name="arch" type="xml">
-            <field name="error_code" position="after">
+            <field name="failure_type" position="after">
                 <field name="error_detail" />
             </field>
         </field>