Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][16.0] fieldservice: improved views concerning categories & tags #1112

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[IMP][16.0] fieldservice: improved views concerning categories & tags #1112

merged 1 commit into from
Aug 25, 2023

Conversation

NICO-SOLUTIONS
Copy link
Member

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @max3903, @wolfhall,
some modules you are maintaining are being modified, check this out!

@NICO-SOLUTIONS NICO-SOLUTIONS changed the title [IMP][14.0] fieldservice: improved views concerning categories & tags [IMP][16.0] fieldservice: improved views concerning categories & tags Aug 13, 2023
@NICO-SOLUTIONS NICO-SOLUTIONS marked this pull request as ready for review August 13, 2023 12:21
@max3903 max3903 added this to the 16.0 milestone Aug 14, 2023
@max3903 max3903 self-assigned this Aug 14, 2023
hparfr
hparfr requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these improvments.

I have remarks about Partner-Tags.
I'm ok with the rest of the proposed changes.

fieldservice/views/fsm_location.xml Outdated Show resolved Hide resolved
@NICO-SOLUTIONS
[IMP] improved views concerning categories & tags
4d2d461 
- added groups-access to tag-ids used in views, to only show tags if "manage tags" (fsm.tags) is enabled
- added groups-access to category_ids used in views, to only show category if "manage categories" (fsm.category) is enabled
hparfr
hparfr approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NICO-SOLUTIONS

@hparfr
Copy link
Contributor

hparfr commented Aug 25, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1112-by-hparfr-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5defc75 into OCA:16.0 Aug 25, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f120319. Thanks a lot for contributing to OCA. ❤️

@NICO-SOLUTIONS NICO-SOLUTIONS deleted the 16.0-fix-fsm-categ-and-tags branch August 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NICO-SOLUTIONS @OCA-git-bot @hparfr @max3903