Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when installing existing addon from same repo from a PR #69

Closed
sbidoul opened this issue Mar 16, 2024 · 0 comments · Fixed by #72
Closed

Issue when installing existing addon from same repo from a PR #69

sbidoul opened this issue Mar 16, 2024 · 0 comments · Fixed by #72
Labels
bug Something isn't working

Comments

@sbidoul
Copy link
Member

sbidoul commented Mar 16, 2024

Say you have a repo with addons A and B.

Say you have a PR with changes to B that depend on a changes in an unmerged PR to A . In that PR, test-requirements.txt has a git reference to A.

In that case, it is unclear if the PR to A will have precendence over A found in the addons path (it is deterministic but fragile and not guaranteed to not change in the future).

When using editable installation mode (#62) there will likely be a conflict between the PR to A and -e A that pip will not be able to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant