[18.0][MIG] partner_title_order: Migration to 18.0 #1862
Conversation
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/fr/
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_title_order Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_title_order/es/
| @@ -14,7 +14,7 @@ def test_default_order(self): | |||
| partner_titles = self.env["res.partner.title"].search([]) | |||
| self.assertEqual( | |||
| partner_titles.mapped("name"), | |||
| partner_titles.sorted(lambda x: x.name).mapped("name"), | |||
| partner_titles.sorted(lambda x: (x.sequence, x.name)).mapped("name"), | |||
There was a problem hiding this comment.
Was this change because the test failed ?
IMO it should not have, all sequence fields should have been set to 10 ?
Just a question to understand the change.
There was a problem hiding this comment.
That was my mistake! There was a bit of confusion between two test cases, which led to my change in that part.
Kimkhoi3010
force-pushed
the
18.0-mig-partner_title_order
branch
from
40cba64
to
340a7f5
Compare
|
/ocabot migration partner_title_order |
|
|
||
|
|
||
| class TestPartnerTitle(SavepointCase): | ||
| class TestPartnerTitle(common.TransactionCase): |
There was a problem hiding this comment.
@Kimkhoi3010 FYI, to avoid the tracking_disable context change here under, you can use BaseCommon class from base addon instead.
There was a problem hiding this comment.
hello @rousseldenis thanks for your time.
There was a problem hiding this comment.
Hello @Kimkhoi3010 , I think @rousseldenis was talking about this base class: https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/tests/common.py#L21 (that is leveraging the DISABLED_MAIL_CONTEXT keys automatically)
I cannot see this change with your push, can you check please?
Kimkhoi3010
force-pushed
the
18.0-mig-partner_title_order
branch
from
340a7f5
to
8c6150b
Compare
No description provided.