Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity key behavior with started jobs #712

Open
rousseldenis opened this issue Nov 28, 2024 · 1 comment
Open

Identity key behavior with started jobs #712

rousseldenis opened this issue Nov 28, 2024 · 1 comment
Labels

Comments

@rousseldenis
Copy link
Contributor

@guewen do you know the reason why 'started' state is not taken into account for identity_key management?

e.g.: a started job with a long execution. A channel of four. Trigger the delay function four times. Four jobs are created even with the identity parameter.

I think that state should be taken into account too. What do you think of?

@guewen
Copy link
Member

guewen commented Nov 28, 2024

Hi @rousseldenis , both use cases are valid actually.
Sometimes you'd want a new job when a job is already started and sometimes you want to wait the job to be finished until you have a new one. See this discussion: #546 (comment)

So we need a way to decide whether it should be considering started jobs or not. I think it could be on queue.job.function, as it would not make any sense to have a different scope for the same job function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants