Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ENH] queue_job: identity_key enhancements #544

Closed
wants to merge 1 commit into from
Closed

[14.0] [ENH] queue_job: identity_key enhancements #544

wants to merge 1 commit into from

Conversation

richard-willdooit
Copy link

  1. In production, a job which is waiting dependencies or which has started, but not completed, should not be repeated if the identity_key matches.
  2. In tests, the mock queue handler is now enhanced to allow better mimicking of the identity_key blocks from production.
  3. In tests, the mock queue handler now clears the enqueued jobs after performing them, to better reproduce what a production environment would do.

[14.0] [ENH] queue_job: identity_key enhancements
c54960f 
1. In production, a job which is waiting dependencies or which
has started, but not completed, should not be repeated if
the identity_key matches.
2. In tests, the mock queue handler is now enhanced to allow
better mimicking of the identity_key blocks from production.
3. In tests, the mock queue handler now clears the enqueued jobs
after performing them, to better reproduce what a production
environment would do.
@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 15, 2023
simahawk
simahawk approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @guewen can you have a look?

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 18, 2023
@simahawk
Copy link
Contributor

@guewen gentle ping :)

@guewen
Copy link
Member

guewen commented Nov 14, 2023

@simahawk I was still expecting this change: #546 (comment)

@richard-willdooit
Copy link
Author

@guewen @simahawk Oh dear, guys, many apologies - I will aim to revisit this before the end of the month.

@simahawk simahawk mentioned this pull request Nov 21, 2023
Merged
@simahawk
Copy link
Contributor

@richard-willdooit I really need to move this fwd. I hope you don't mind if I'm finishing your work on #581

@simahawk simahawk closed this Nov 21, 2023
@simahawk simahawk mentioned this pull request Nov 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-willdooit @OCA-git-bot @simahawk @guewen