From dca2a975e7c15590c4ddcdbda1ee850782159ce3 Mon Sep 17 00:00:00 2001
From: Akim Juillerat <akim.juillerat@camptocamp.com>
Date: Tue, 29 Oct 2024 17:04:21 +0100
Subject: [PATCH] [IMP] mass_edit: Reduce create function complexity

---
 .../wizard/mass_editing_wizard.py             | 68 ++++++++++---------
 1 file changed, 36 insertions(+), 32 deletions(-)

diff --git a/server_action_mass_edit/wizard/mass_editing_wizard.py b/server_action_mass_edit/wizard/mass_editing_wizard.py
index 8f0d79b89d..6393cf3acf 100644
--- a/server_action_mass_edit/wizard/mass_editing_wizard.py
+++ b/server_action_mass_edit/wizard/mass_editing_wizard.py
@@ -245,43 +245,13 @@ def _clean_check_company_field_domain(self, TargetModel, field, field_info):
         return field_info
 
     @api.model_create_multi
-    def create(self, vals_list):  # noqa: C901
+    def create(self, vals_list):
         server_action_id = self.env.context.get("server_action_id")
         server_action = self.env["ir.actions.server"].sudo().browse(server_action_id)
         active_ids = self.env.context.get("active_ids", [])
         if server_action and active_ids:
             for vals in vals_list:
-                values = {}
-                for key, val in vals.items():
-                    if key.startswith("selection_"):
-                        split_key = key.split("__", 1)[1]
-                        if val == "set" or val == "add_o2m":
-                            values.update({split_key: vals.get(split_key, False)})
-
-                        elif val == "set_o2m":
-                            values.update(
-                                {split_key: [(6, 0, [])] + vals.get(split_key, [])}
-                            )
-
-                        elif val == "remove":
-                            values.update({split_key: False})
-
-                        elif val == "remove_m2m":
-                            m2m_list = []
-                            if vals.get(split_key):
-                                for m2m_id in vals.get(split_key)[0][2]:
-                                    m2m_list.append((3, m2m_id))
-                            if m2m_list:
-                                values.update({split_key: m2m_list})
-                            else:
-                                values.update({split_key: [(5, 0, [])]})
-
-                        elif val == "add":
-                            m2m_list = []
-                            for m2m_id in vals.get(split_key, False)[0][2]:
-                                m2m_list.append((4, m2m_id))
-                            values.update({split_key: m2m_list})
-
+                values = self._prepare_write_values(vals)
                 if values:
                     model = self.env[server_action.model_id.model].with_context(
                         mass_edit=True
@@ -316,6 +286,40 @@ def create(self, vals_list):  # noqa: C901
                         records.write(values)
         return super().create([{}])
 
+    def _prepare_write_values(self, vals):
+        values = {}
+        for key, val in vals.items():
+            if key.startswith("selection_"):
+                split_key = key.split("__", 1)[1]
+                if val == "set" or val == "add_o2m":
+                    values.update({split_key: vals.get(split_key, False)})
+
+                elif val == "set_o2m":
+                    values.update(
+                        {split_key: [(6, 0, [])] + vals.get(split_key, [])}
+                    )
+
+                elif val == "remove":
+                    values.update({split_key: False})
+
+                elif val == "remove_m2m":
+                    m2m_list = []
+                    if vals.get(split_key):
+                        for m2m_id in vals.get(split_key)[0][2]:
+                            m2m_list.append((3, m2m_id))
+                    if m2m_list:
+                        values.update({split_key: m2m_list})
+                    else:
+                        values.update({split_key: [(5, 0, [])]})
+
+                elif val == "add":
+                    m2m_list = []
+                    for m2m_id in vals.get(split_key, False)[0][2]:
+                        m2m_list.append((4, m2m_id))
+                    values.update({split_key: m2m_list})
+        return values
+
+
     def _prepare_create_values(self, vals_list):
         return vals_list