Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] stock_barcodes_elaboration: New module for display elaborations in barcode interface #508

Merged
merged 1 commit into from
Apr 6, 2024
Merged

[15.0][ADD] stock_barcodes_elaboration: New module for display elaborations in barcode interface #508

merged 1 commit into from
Apr 6, 2024

Conversation

carlosdauden
Copy link
Contributor

@carlosdauden carlosdauden marked this pull request as draft April 21, 2023 13:22
@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_barcodes_elaboration branch from a9f5cfd to b0f4c4c Compare April 21, 2023 17:13
@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_barcodes_elaboration branch 2 times, most recently from af68b98 to 72fc851 Compare May 30, 2023 16:12
@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_barcodes_elaboration branch from 43126db to 1292e8e Compare August 3, 2023 14:42
@elvise
Copy link

elvise commented Sep 28, 2023

@carlosdauden can you rebase ?

@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_barcodes_elaboration branch from 1292e8e to ec29375 Compare September 28, 2023 14:11
@carlosdauden
Copy link
Contributor Author

Rebased

@carlosdauden carlosdauden marked this pull request as ready for review September 28, 2023 14:12
@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_barcodes_elaboration branch from ec29375 to 3b1f6a0 Compare November 24, 2023 08:29
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 24, 2024
@carlosdauden
Copy link
Contributor Author

Ping @sergio-teruel @CarlosRoca13

CarlosRoca13
CarlosRoca13 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

Just a minor comment

@pedrobaeza pedrobaeza added this to the 15.0 milestone Mar 25, 2024
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 25, 2024
@carlosdauden carlosdauden force-pushed the 15.0-ADD-stock_barcodes_elaboration branch from 3b1f6a0 to 24e01a9 Compare April 5, 2024 15:38
@carlosdauden
Copy link
Contributor Author

ping @sergio-teruel ready to merge

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-508-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5d2c61d into OCA:15.0 Apr 6, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c20fc2b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-ADD-stock_barcodes_elaboration branch April 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-teruel sergio-teruel sergio-teruel approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@carlosdauden @elvise @OCA-git-bot @pedrobaeza @sergio-teruel @CarlosRoca13