Add observationPeriodCohort

[edward-burn]

observationPeriodCohort - another base cohort function that similar to measurementCohort that adds some extra options. For observationPeriodCohort, the extra argument would relate to the period_type_concept_id

[catalamarti]

If we do this, should demographicsCohort exist?

Having observationPeriodCohort + trimDemographics would do the trick right?

@edward-burn @nmercadeb

[edward-burn]

Well for me observationPeriodCohort wouldn't have any requirement on sex, age etc. It is just to allow for observation period table extra arguments (like we have for measurementCohort and could have for more tables #191)

[catalamarti]

Yep, the one that I propose to deprecate is demographicsCohort

[edward-burn]

Perhaps, but I imagine just running demographicsCohort would be quicker than using observationPeriodCohort + trimDemographics, no?

[catalamarti]

I think it should be the same basically that is what is done inside (if I remember corrctly)