Remove direct call to bit64 S3 method to avoid issues in the future. Fixes #303

schuemie · schuemie · commit 0794d6ea6e6f · 2025-01-31T09:39:09.000+01:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,11 @@
+DatabaseConnector 6.4.1
+=======================
+
+Bugfixes:
+
+- Remove direct call to `bit64` S3 method to avoid issues in the future.
+
+
 DatabaseConnector 6.4.0
 =======================
 
diff --git a/R/Sql.R b/R/Sql.R
@@ -81,7 +81,7 @@ convertInteger64ToNumeric <- function(x) {
   if (any(x >= maxInt64 | x <= -maxInt64, na.rm = TRUE)) {
     abort("The data contains integers >= 2^53, and converting those to R's numeric type leads to precision loss. Consider using smaller integers, converting the integers to doubles on the database side, or using `options(databaseConnectorInteger64AsNumeric = FALSE)`.")
   }
-  return(bit64::as.double.integer64(x))
+  return(as.double(x))
 }
 
 parseJdbcColumnData <- function(batchedQuery,

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ convertInteger64ToNumeric <- function(x) {`
`81`	`81`	`if (any(x >= maxInt64 \| x <= -maxInt64, na.rm = TRUE)) {`
`82`	`82`	abort("The data contains integers >= 2^53, and converting those to R's numeric type leads to precision loss. Consider using smaller integers, converting the integers to doubles on the database side, or using `options(databaseConnectorInteger64AsNumeric = FALSE)`.")
`83`	`83`	`}`
`84`		`- return(bit64::as.double.integer64(x))`
	`84`	`+ return(as.double(x))`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`parseJdbcColumnData <- function(batchedQuery,`