Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to override the EunomiaDatasets URL with an optional environment variable #40

Open
ablack3 opened this issue Apr 7, 2023 · 1 comment · Fixed by #48
Open
Assignees
Milestone

Comments

@ablack3
Copy link
Collaborator

ablack3 commented Apr 7, 2023

In the soon-to-be-released version of Eunomia users will be able to choose from multiple Eunomia datasets. These datasets are hosted in a separate github repo called EunomiaDatasets. It would be helpful if users could override this location and point to a fork of EunomiaDatasets for testing.

Currently the location is hard coded here:

baseUrl <- "https://raw.githubusercontent.com/OHDSI/EunomiaDatasets/main/datasets"

Concrete use case:
I created a PR on EunomiaDatasets to fix an issue but I have no way to test that that my change works until after it is accepted. Ideally I'd like to be able to point to Eunomia to my personal fork and test that my change fixes the issue. I would propose using an environment variable for the location with the current location being used if the environment variable is unset.

What do you think @fdefalco?

@ablack3 ablack3 changed the title Allow users to override the EunomiaDatasets path Allow users to override the EunomiaDatasets path with an optional environment variable Apr 7, 2023
@ablack3 ablack3 changed the title Allow users to override the EunomiaDatasets path with an optional environment variable Allow users to override the EunomiaDatasets URL with an optional environment variable Apr 7, 2023
@fdefalco fdefalco added this to the v2.0.0 milestone May 23, 2023
@ginberg ginberg self-assigned this May 30, 2023
ginberg added a commit that referenced this issue May 30, 2023
@ablack3
Copy link
Collaborator Author

ablack3 commented Nov 7, 2024

Thank you! This change should allow us to set up an S3 bucket with example datasets that are larger than what will fit in github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants