Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to other repos and avoiding code duplication #4

Open
msuchard opened this issue Oct 11, 2018 · 1 comment
Open

Linking to other repos and avoiding code duplication #4

msuchard opened this issue Oct 11, 2018 · 1 comment

Comments

@msuchard
Copy link
Member

Here is an idea:

ShinyDeploy should consist of submodules to the original repos in which we are developing apps. Each submodule could link, e.g., to a deploy branch, so that development could still happen in master.

Here's an example:

Legend and ShinyDeploy link via submodule to LegendBasicViewer. The Legend link is for all branches and the ShinyDeploy link is for the deploy branch.

Other ideas?

@schuemie
Copy link
Member

In general I think this is a good idea, but I'm a bit vague on the details. Are you saying the LegendBasicViewer folder in the ShinyDeploy repo master branch would be linked to the LegendBasicViewer folder in the Legend repo deploy branch, such that any updates on the Legend repo side would automatically appear in the ShinyDeploy repo?

A related question: what happened to the submodule link for SkeletonCompartiveEffectStudy? The copy in StudyProtocolSandbox no longer is up to date with the SkeletonCompartiveEffectStudy repo.

jreps pushed a commit that referenced this issue Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants