Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GoogleBigQueryJDBC + dependencies from repository, add build instructions #379

Open
janblom opened this issue Jun 14, 2023 · 1 comment
Assignees
Labels

Comments

@janblom
Copy link
Collaborator

janblom commented Jun 14, 2023

Describe the bug
While the licenses of Google BigQuery and its dependencies allow using them within WhiteRabbit without restrictions, including them in the WR project, or packaging them as part of a release is not permitted. From the download site: "You can use these drivers without any additional license requirements, but cannot redistribute the drivers as part of an application." (retrieved at creation date of this issue).
The next (major) release of WhiteRabbit should not contain these dependencies. Instead, the source tree should contain a stub directory where anyone who wishes to use WhiteRabbit with Google BigQuery can download the dependencies from the site mentioned above, and compile WhiteRabbit for use with Google BigQuery. The stub directory should contain a README with instructions how to do this.

Additional context
See OHDSI WebAPI as an exanple of how to set this up.

@janblom janblom added the bug label Jun 14, 2023
@janblom janblom self-assigned this Jun 14, 2023
@blootsvoets
Copy link
Collaborator

blootsvoets commented Jun 14, 2023

I haven't evaluated all of the dependent libraries, but I would gander that there's more database libraries WR uses that have similar don't distribute or personal use licenses...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants