From 468fd515e60bca77abaaf86b971214c5e340c796 Mon Sep 17 00:00:00 2001 From: keef3ar <35760257+keef3ar@users.noreply.github.com> Date: Tue, 3 Oct 2023 16:21:30 +0400 Subject: [PATCH] Optimize BinaryWriter memory usage (#591) - Replace continuous buffer concatenation with a buffer array to reduce intermediate buffer creations. - This approach mitigates potential memory leaks and improves performance, especially for large files. --- gramjs/extensions/BinaryWriter.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gramjs/extensions/BinaryWriter.ts b/gramjs/extensions/BinaryWriter.ts index a19a1520..2d8df7b6 100644 --- a/gramjs/extensions/BinaryWriter.ts +++ b/gramjs/extensions/BinaryWriter.ts @@ -1,15 +1,15 @@ export class BinaryWriter { - private _stream: Buffer; + private readonly _buffers: Buffer[]; constructor(stream: Buffer) { - this._stream = stream; + this._buffers = [stream]; } write(buffer: Buffer) { - this._stream = Buffer.concat([this._stream, buffer]); + this._buffers.push(buffer); } - getValue() { - return this._stream; + getValue(): Buffer { + return Buffer.concat(this._buffers); } }