Merge pull request #14 from ONE-F-M/186579971

BUG:UPON COURSE CREATION

one_lms/www/courses/create.py

@@ -3,6 +3,7 @@
 	redirect_to_courses_list,
 	can_create_courses,
 	has_course_moderator_role,
+ 	has_course_instructor_role
 )
 from frappe import _
 
@@ -15,14 +16,14 @@ def get_context(context):
 	except KeyError:
 		redirect_to_courses_list()
 
-	if not can_create_courses():
+	if not can_create_courses(course_name) and course_name != "new-course":
 		message = "You do not have permission to access this page."
 		if frappe.session.user == "Guest":
 			message = "Please login to access this page."
 
 		raise frappe.PermissionError(_(message))
 
-	if course_name == "new-course":
+	if course_name == "new-course" and has_course_instructor_role():
 		context.course = frappe._dict()
 		context.course.edit_mode = True
 		context.membership = None

one_lms/www/courses/index.py

@@ -7,6 +7,7 @@
 	has_course_moderator_role,
 	get_courses_under_review,
 	get_average_rating,
+ 	has_course_instructor_role,
 )
 from lms.overrides.user import get_enrolled_courses, get_authored_courses
 
@@ -20,7 +21,16 @@ def get_context(context):
 	context.created_courses = get_authored_courses(None, False)
 	context.review_courses = get_courses_under_review()
 	context.restriction = check_profile_restriction()
-	context.show_creators_section = can_create_courses()
+	portal_course_creation = frappe.db.get_single_value(
+		"LMS Settings", "portal_course_creation"
+	)
+	context.show_creators_section = (
+		True
+		if portal_course_creation == "Anyone"
+		or has_course_moderator_role()
+		or has_course_instructor_role()
+		else False
+	)
 	context.show_review_section = (
 		has_course_moderator_role() and frappe.session.user != "Guest"
 	)