fix email source null check (#7146)

ORCID · Nov 26, 2024 · 108b56f · 108b56f
1 parent 71e8ec9
commit 108b56f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/orcid-core/src/main/java/org/orcid/core/utils/SourceUtils.java b/orcid-core/src/main/java/org/orcid/core/utils/SourceUtils.java
@@ -64,7 +64,7 @@ public void setSourceName(SourceAware sourceAware) {
         }
 
         String providedSourceName = source.getSourceName() != null ? source.getSourceName().getContent() : null;
-        if (providedSourceName == null || providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
+        if (providedSourceName != null && providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
             return;
         }
 

diff --git a/orcid-core/src/main/java/org/orcid/core/utils/v3/SourceUtils.java b/orcid-core/src/main/java/org/orcid/core/utils/v3/SourceUtils.java
@@ -73,7 +73,7 @@ public void setSourceName(SourceAware sourceAware) {
         }
 
         String providedSourceName = source.getSourceName() != null ? source.getSourceName().getContent() : null;
-        if (providedSourceName == null || providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
+        if (providedSourceName != null && providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
             return;
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -64,7 +64,7 @@ public void setSourceName(SourceAware sourceAware) { @@
             }
             String providedSourceName = source.getSourceName() != null ? source.getSourceName().getContent() : null;
-            if (providedSourceName == null || providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
+            if (providedSourceName != null && providedSourceName.equals(ORCID_EMAIL_VALIDATOR_CLIENT_NAME)) {
                 return;
             }
@@ Expand Down @@