fix email source npe (#7145)

ORCID · Nov 25, 2024 · 53586d0 · 53586d0
1 parent ed7cf7f
commit 53586d0
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/orcid-core/src/main/java/org/orcid/core/utils/SourceEntityUtils.java b/orcid-core/src/main/java/org/orcid/core/utils/SourceEntityUtils.java
@@ -241,7 +241,14 @@ public static boolean isTheSameForPermissionChecking(Source activeSource, Source
      */
     public Source convertEmailSourceToOrcidValidator(Source source) {
         source.setSourceOrcid(null);
-        source.getSourceName().setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+        SourceName sourceName = source.getSourceName();
+        if (sourceName != null) {
+            sourceName.setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+        } else {
+            sourceName = new SourceName();
+            sourceName.setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+            source.setSourceName(sourceName);
+        }
         SourceClientId sourceClientId = new SourceClientId(ORCID_EMAIL_VALIDATOR_CLIENT_ID);
         sourceClientId.setPath(ORCID_EMAIL_VALIDATOR_CLIENT_ID);
         sourceClientId.setHost(orcidUrlManager.getBaseHost());
@@ -258,7 +265,14 @@ public Source convertEmailSourceToOrcidValidator(Source source) {
      */
     public org.orcid.jaxb.model.common_v2.Source convertEmailSourceToOrcidValidator(org.orcid.jaxb.model.common_v2.Source source) {
         source.setSourceOrcid(null);
-        source.getSourceName().setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+        org.orcid.jaxb.model.common_v2.SourceName sourceName = source.getSourceName();
+        if (sourceName != null) {
+            sourceName.setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+        } else {
+            sourceName = new org.orcid.jaxb.model.common_v2.SourceName();
+            sourceName.setContent(ORCID_EMAIL_VALIDATOR_CLIENT_NAME);
+            source.setSourceName(sourceName);
+        }
         org.orcid.jaxb.model.common_v2.SourceClientId sourceClientId = new org.orcid.jaxb.model.common_v2.SourceClientId(ORCID_EMAIL_VALIDATOR_CLIENT_ID);
         sourceClientId.setPath(ORCID_EMAIL_VALIDATOR_CLIENT_ID);
         sourceClientId.setHost(orcidUrlManager.getBaseHost());