From 550533c4c8d09fd89f121d35868b800c407128be Mon Sep 17 00:00:00 2001 From: Daniel Palafox Date: Fri, 20 Oct 2023 17:58:16 -0500 Subject: [PATCH] fix: Update external identifier is validates method --- .../org/orcid/pojo/summary/ExternalIdentifiersSummary.java | 2 +- .../web/controllers/PublicRecordControllerTest.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/orcid-core/src/main/java/org/orcid/pojo/summary/ExternalIdentifiersSummary.java b/orcid-core/src/main/java/org/orcid/pojo/summary/ExternalIdentifiersSummary.java index d4593ba47a7..61fab224d86 100644 --- a/orcid-core/src/main/java/org/orcid/pojo/summary/ExternalIdentifiersSummary.java +++ b/orcid-core/src/main/java/org/orcid/pojo/summary/ExternalIdentifiersSummary.java @@ -86,7 +86,7 @@ public static ExternalIdentifiersSummary valueOf(PersonExternalIdentifier person } if (personExternalIdentifier.getSource() != null) { - form.setValidated(SourceUtils.isSelfAsserted(personExternalIdentifier.getSource(), orcid)); + form.setValidated(!SourceUtils.isSelfAsserted(personExternalIdentifier.getSource(), orcid)); } } return form; diff --git a/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicRecordControllerTest.java b/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicRecordControllerTest.java index ea2ec422e91..f910d1a146a 100644 --- a/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicRecordControllerTest.java +++ b/orcid-web/src/test/java/org/orcid/frontend/web/controllers/PublicRecordControllerTest.java @@ -155,8 +155,8 @@ public void testGetRecordSummary() { // Check external identifiers assertNotNull(record.getExternalIdentifiers()); assertEquals(3, record.getExternalIdentifiers().size()); - - // Added by member + + // User OBO assertEquals(String.valueOf(19), record.getExternalIdentifiers().get(0).getId()); assertEquals("self_public_user_obo_type", record.getExternalIdentifiers().get(0).getCommonName()); assertEquals("self_public_user_obo_ref", record.getExternalIdentifiers().get(0).getReference()); @@ -168,7 +168,7 @@ public void testGetRecordSummary() { assertEquals("self_public_ref", record.getExternalIdentifiers().get(1).getReference()); assertEquals("http://ext-id/self/public", record.getExternalIdentifiers().get(1).getUrl()); assertFalse(record.getExternalIdentifiers().get(1).isValidated()); - // User OBO + // Added by member assertEquals(String.valueOf(13), record.getExternalIdentifiers().get(2).getId()); assertEquals("public_type", record.getExternalIdentifiers().get(2).getCommonName()); assertEquals("public_ref", record.getExternalIdentifiers().get(2).getReference());