Fix unit tests

ORCID · Dec 10, 2024 · 82a2a66 · 82a2a66
1 parent d8b2e38
commit 82a2a66
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/...-pub-web/src/test/java/org/orcid/api/publicV2/server/PublicV2ApiServiceDelegatorTest.java b/...-pub-web/src/test/java/org/orcid/api/publicV2/server/PublicV2ApiServiceDelegatorTest.java
@@ -25,7 +25,6 @@
 import org.orcid.api.publicV2.server.delegator.PublicV2ApiServiceDelegator;
 import org.orcid.api.publicV2.server.delegator.impl.PublicV2ApiServiceDelegatorImpl;
 import org.orcid.core.api.OrcidApiConstants;
-import org.orcid.core.exception.DeactivatedException;
 import org.orcid.core.exception.OrcidBadRequestException;
 import org.orcid.core.exception.OrcidNonPublicElementException;
 import org.orcid.core.exception.SearchStartParameterLimitExceededException;
@@ -570,8 +569,8 @@ public void testViewEmails() {
         assertEquals(Visibility.PUBLIC.value(), email.getVisibility().value());
         assertEquals(Visibility.PUBLIC.value(), email2.getVisibility().value());
         assertEquals("/0000-0000-0000-0003/email", emails.getPath());
-        assertEquals("APP-5555555555555555", email.getSource().retrieveSourcePath());
-        assertEquals("Source Client 1", email.getSource().getSourceName().getContent());
+        assertEquals("0000-0000-0000-0000", email.getSource().retrieveSourcePath());
+        assertEquals("ORCID email validation", email.getSource().getSourceName().getContent());
         assertNull(email.getSource().getSourceOrcid());
         assertEquals("0000-0000-0000-0000", email2.getSource().retrieveSourcePath());
         assertEquals("ORCID email validation", email2.getSource().getSourceName().getContent());
@@ -1305,8 +1304,8 @@ private void validatePerson(Person person) {
         assertNotNull(email.getLastModifiedDate().getValue());
         assertNotNull(email2.getLastModifiedDate());
         assertNotNull(email2.getLastModifiedDate().getValue());
-        assertEquals("APP-5555555555555555", email.getSource().retrieveSourcePath());
-        assertEquals("Source Client 1", email.getSource().getSourceName().getContent());
+        assertEquals("0000-0000-0000-0000", email.getSource().retrieveSourcePath());
+        assertEquals("ORCID email validation", email.getSource().getSourceName().getContent());
         assertNull(email.getSource().getSourceOrcid());
         assertEquals("0000-0000-0000-0000", email2.getSource().retrieveSourcePath());
         assertEquals("ORCID email validation", email2.getSource().getSourceName().getContent());

diff --git a/...-pub-web/src/test/java/org/orcid/api/publicV3/server/PublicV3ApiServiceDelegatorTest.java b/...-pub-web/src/test/java/org/orcid/api/publicV3/server/PublicV3ApiServiceDelegatorTest.java
@@ -597,8 +597,8 @@ public void testViewEmails() {
         assertEquals(Visibility.PUBLIC.value(), email.getVisibility().value());
         assertEquals(Visibility.PUBLIC.value(), email2.getVisibility().value());
         assertEquals("/0000-0000-0000-0003/email", emails.getPath());
-        assertEquals("APP-5555555555555555", email.getSource().retrieveSourcePath());
-        assertEquals("Source Client 1", email.getSource().getSourceName().getContent());
+        assertEquals("0000-0000-0000-0000", email.getSource().retrieveSourcePath());
+        assertEquals("ORCID email validation", email.getSource().getSourceName().getContent());
         assertNull(email.getSource().getSourceOrcid());
         assertEquals("0000-0000-0000-0000", email2.getSource().retrieveSourcePath());
         assertEquals("ORCID email validation", email2.getSource().getSourceName().getContent());
@@ -1836,9 +1836,9 @@ private void validatePerson(Person person) {
         assertNotNull(email.getLastModifiedDate().getValue());
         assertNotNull(email2.getLastModifiedDate());
         assertNotNull(email2.getLastModifiedDate().getValue());
-        assertEquals("APP-5555555555555555", email.getSource().retrieveSourcePath());
+        assertEquals("0000-0000-0000-0000", email.getSource().retrieveSourcePath());
         assertNull(email.getSource().getSourceOrcid());
-        assertEquals("Source Client 1", email.getSource().getSourceName().getContent());
+        assertEquals("ORCID email validation", email.getSource().getSourceName().getContent());
         assertEquals("0000-0000-0000-0000", email2.getSource().retrieveSourcePath());
         assertNull(email2.getSource().getSourceOrcid());
         assertEquals("ORCID email validation", email2.getSource().getSourceName().getContent());