From e46385e68e6f2398b4352c0d2c523d266696f70c Mon Sep 17 00:00:00 2001
From: Angel Montenegro <a.montenegro@orcid.org>
Date: Wed, 18 Dec 2024 11:23:40 -0600
Subject: [PATCH] Generated by script must not be null (#7159)

* generated_by_script must not be null

* generated_by_script must not be null
---
 ..._script_column_to_profile_email_domain.xml | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/orcid-persistence/src/main/resources/db/updates/add_generated_by_script_column_to_profile_email_domain.xml b/orcid-persistence/src/main/resources/db/updates/add_generated_by_script_column_to_profile_email_domain.xml
index 5c4bda80a8..a5b7bb58be 100644
--- a/orcid-persistence/src/main/resources/db/updates/add_generated_by_script_column_to_profile_email_domain.xml
+++ b/orcid-persistence/src/main/resources/db/updates/add_generated_by_script_column_to_profile_email_domain.xml
@@ -1,6 +1,6 @@
 <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
-	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-2.0.xsd">
+				   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+				   xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-2.0.xsd">
 
 	<changeSet author="Andrej Romanov" id="ADD-GENERATED-BY-SCRIPT-TO-PROFILE-EMAIL-DOMAIN-TABLE">
 		<preConditions onFail="MARK_RAN">
@@ -9,14 +9,24 @@
 			</not>
 		</preConditions>
 		<sql>ALTER TABLE profile_email_domain ADD generated_by_script boolean default false;</sql>
-    </changeSet>
+	</changeSet>
 
 	<changeSet author="Andrej Romanov" id="UPDATE-GENERATED-BY-SCRIPT-BASED-ON-CREATED-DATE" dbms="postgresql">
 		<sql>UPDATE profile_email_domain SET generated_by_script = true WHERE date_created &lt; '2024-10-28';</sql>
 	</changeSet>
 
-	<changeSet author="Angel Montenegro" id="SET-FALSE-TO-NULL" dbms="postgresql">
+	<changeSet author="Angel Montenegro" id="SET-FALSE-TO-NULL-VALUES" dbms="postgresql">
 		<sql>UPDATE profile_email_domain SET generated_by_script = false WHERE generated_by_script is null;</sql>
 	</changeSet>
 
-</databaseChangeLog>	
+	<changeSet author="Angel Montenegro" id="SET-FIELD-NOT-NULLABLE" dbms="postgresql">
+		<preConditions onFail="MARK_RAN">
+			<sqlCheck  expectedResult="YES">select is_nullable from information_schema.columns where table_name = 'profile_email_domain' and column_name = 'generated_by_script';</sqlCheck>
+		</preConditions>
+		<addNotNullConstraint
+				columnName="generated_by_script"
+				tableName="profile_email_domain"
+				defaultNullValue="false"/>
+	</changeSet>
+
+</databaseChangeLog>
\ No newline at end of file