Merge branch 'main' into remove-old-togglz

CHANGELOG.md

@@ -1,3 +1,49 @@
+## v2.64.3 - 2024-09-02
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.64.2...v2.64.3)
+
+## v2.64.2 - 2024-08-28
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.64.1...v2.64.2)
+
+## v2.64.1 - 2024-08-26
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.64.0...v2.64.1)
+
+## v2.64.0 - 2024-08-22
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.10...v2.64.0)
+
+## v2.63.10 - 2024-08-22
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.9...v2.63.10)
+
+## v2.63.9 - 2024-08-16
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.8...v2.63.9)
+
+## v2.63.8 - 2024-08-14
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.7...v2.63.8)
+
+- [#7067](https://github.com/ORCID/ORCID-Source/pull/7067): 1. Fixed the correct query string for showing first 10 resutls.
+
+## v2.63.7 - 2024-08-13
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.6...v2.63.7)
+
+## v2.63.6 - 2024-08-12
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.5...v2.63.6)
+
+## v2.63.5 - 2024-08-12
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.4...v2.63.5)
+
+## v2.63.4 - 2024-08-10
+
+[Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.3...v2.63.4)
+
 ## v2.63.3 - 2024-08-06
 
 [Full Changelog](https://github.com/ORCID/ORCID-Source/compare/v2.63.2...v2.63.3)

orcid-api-common/src/main/java/org/orcid/api/common/filter/ApiVersionCheckFilter.java

@@ -12,8 +12,8 @@
 import org.orcid.core.exception.OrcidBadRequestException;
 import org.orcid.core.locale.LocaleManager;
 import org.orcid.core.manager.impl.OrcidUrlManager;
-import org.orcid.core.utils.OrcidStringUtils;
 import org.orcid.pojo.ajaxForm.PojoUtil;
+import org.orcid.utils.OrcidStringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.web.bind.annotation.RequestMethod;
 

orcid-api-common/src/main/java/org/orcid/api/common/filter/DefaultApiVersionFilter.java

@@ -22,9 +22,9 @@
 import org.orcid.core.manager.impl.OrcidUrlManager;
 import org.orcid.core.togglz.Features;
 import org.orcid.core.utils.JsonUtils;
-import org.orcid.core.utils.OrcidStringUtils;
 import org.orcid.jaxb.model.v3.release.error.OrcidError;
 import org.orcid.pojo.ajaxForm.PojoUtil;
+import org.orcid.utils.OrcidStringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.web.filter.OncePerRequestFilter;

orcid-api-common/src/main/java/org/orcid/api/common/filter/TokenTargetFilter.java

@@ -11,7 +11,7 @@
 import org.orcid.core.exception.OrcidUnauthorizedException;
 import org.orcid.core.oauth.OrcidOauth2TokenDetailService;
 import org.orcid.persistence.jpa.entities.ProfileEntity;
-import org.orcid.core.utils.OrcidStringUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.springframework.security.core.Authentication;
 import org.springframework.security.core.context.SecurityContext;
 import org.springframework.security.core.context.SecurityContextHolder;

orcid-api-common/src/main/java/org/orcid/api/common/jaxb/OrcidExceptionMapper.java

@@ -27,8 +27,8 @@
 import org.orcid.core.manager.impl.OrcidUrlManager;
 import org.orcid.core.oauth.OAuthError;
 import org.orcid.core.oauth.OAuthErrorUtils;
-import org.orcid.core.utils.DateUtils;
-import org.orcid.core.utils.OrcidStringUtils;
+import org.orcid.utils.DateUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.orcid.core.version.ApiSection;
 import org.orcid.jaxb.model.message.DeprecatedDate;
 import org.orcid.jaxb.model.message.ErrorDesc;

orcid-api-common/src/main/java/org/orcid/api/common/security/oauth/RevokeTokenEndpointFilter.java

@@ -11,7 +11,7 @@
 import javax.servlet.http.HttpServletResponse;
 
 import org.orcid.core.locale.LocaleManager;
-import org.orcid.core.utils.OrcidStringUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.springframework.security.authentication.AuthenticationProvider;
 import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
 import org.springframework.security.core.Authentication;

orcid-api-web/README.md

@@ -135,11 +135,7 @@ See the current [XSD documentation](https://github.com/ORCID/orcid-model/blob/ma
 
 ## API Limits
 
-**v1.2**
-* Request a second - 8
-* Burst - 40
-
-**v2.0 and above**
+**v2.0, v2.1 and v3.0**
 * Request a second - 24
 * Burst - 40
 

orcid-api-web/src/main/java/org/orcid/api/notificationsV2/server/delegator/impl/NotificationsApiServiceDelegatorImpl.java

@@ -31,7 +31,7 @@
 import org.orcid.jaxb.model.notification.permission_v2.NotificationPermission;
 import org.orcid.jaxb.model.notification_v2.Notification;
 import org.orcid.persistence.jpa.entities.ProfileEntity;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.security.core.Authentication;
 import org.springframework.security.core.context.SecurityContextHolder;

orcid-api-web/src/test/java/org/orcid/api/memberV2/server/delegator/MemberV2ApiServiceDelegator_ActivitiesSummaryTest.java

@@ -51,7 +51,7 @@
 import org.orcid.test.DBUnitTest;
 import org.orcid.test.OrcidJUnit4ClassRunner;
 import org.orcid.test.helper.Utils;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.test.context.ContextConfiguration;
 
 @RunWith(OrcidJUnit4ClassRunner.class)

orcid-api-web/src/test/java/org/orcid/api/memberV2/server/delegator/MemberV2ApiServiceDelegator_GroupIdTest.java

@@ -49,7 +49,7 @@
 import org.orcid.test.DBUnitTest;
 import org.orcid.test.OrcidJUnit4ClassRunner;
 import org.orcid.test.helper.Utils;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.util.ReflectionTestUtils;
 

orcid-api-web/src/test/java/org/orcid/api/memberV2/server/delegator/MemberV2ApiServiceDelegator_WorksTest.java

@@ -75,7 +75,7 @@
 import org.orcid.test.OrcidJUnit4ClassRunner;
 import org.orcid.test.TargetProxyHelper;
 import org.orcid.test.helper.Utils;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.mock.web.MockHttpServletRequest;
 import org.springframework.test.context.ContextConfiguration;

orcid-api-web/src/test/java/org/orcid/api/memberV3/server/delegator/MemberV3ApiServiceDelegator_ActivitiesSummaryTest.java

@@ -19,7 +19,7 @@
 import org.junit.runner.RunWith;
 import org.orcid.api.common.util.v3.ActivityUtils;
 import org.orcid.core.exception.OrcidUnauthorizedException;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.orcid.core.utils.SecurityContextTestUtils;
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecord;
 import org.orcid.jaxb.model.message.ScopePathType;

orcid-api-web/src/test/java/org/orcid/api/memberV3/server/delegator/MemberV3ApiServiceDelegator_GroupIdTest.java

@@ -55,7 +55,7 @@
 import org.orcid.test.DBUnitTest;
 import org.orcid.test.OrcidJUnit4ClassRunner;
 import org.orcid.test.helper.v3.Utils;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.util.ReflectionTestUtils;
 

orcid-api-web/src/test/java/org/orcid/api/memberV3/server/delegator/MemberV3ApiServiceDelegator_WorksTest.java

@@ -81,7 +81,7 @@
 import org.orcid.test.OrcidJUnit4ClassRunner;
 import org.orcid.test.TargetProxyHelper;
 import org.orcid.test.helper.v3.Utils;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.mock.web.MockHttpServletRequest;
 import org.springframework.test.context.ContextConfiguration;

orcid-api-web/tutorial/search.md

@@ -402,7 +402,7 @@ Description: Search for records modified between January 1, 2018 and today
 
 Paging: First 10 results
 
-URL: ```https://pub.sandbox.orcid.org/v3.0/search/?q=profile-last-modified-date:%5B2018-01-01T00:00:00Z%20TO%20NOW%5D&start=1&rows=10```
+URL: ```https://pub.sandbox.orcid.org/v3.0/search/?q=profile-last-modified-date:%5B2018-01-01T00:00:00Z%20TO%20NOW%5D&start=0&rows=10```
 
 ### Example 14
 

orcid-core/pom.xml

@@ -316,12 +316,7 @@
             <version>2.0.1</version>
         </dependency>
 
-        <!-- https://mvnrepository.com/artifact/org.jsoup/jsoup -->
-		<dependency>
-			<groupId>org.jsoup</groupId>
-			<artifactId>jsoup</artifactId>
-			<version>1.15.4</version>
-		</dependency>
+
 		<!-- https://mvnrepository.com/artifact/javax.ws.rs/javax.ws.rs-api -->
 		<dependency>
 		    <groupId>javax.ws.rs</groupId>

orcid-core/src/main/java/org/orcid/core/adapter/impl/MapperFacadeFactory.java

@@ -110,7 +110,7 @@
 import org.orcid.persistence.jpa.entities.StartDateEntity;
 import org.orcid.persistence.jpa.entities.WorkEntity;
 import org.orcid.pojo.ajaxForm.PojoUtil;
-import org.orcid.core.utils.OrcidStringUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.springframework.beans.factory.FactoryBean;
 
 import ma.glasnost.orika.CustomMapper;

orcid-core/src/main/java/org/orcid/core/aop/ProfileLastModifiedAspect.java

@@ -12,7 +12,7 @@
 import org.orcid.persistence.dao.ProfileLastModifiedDao;
 import org.orcid.persistence.jpa.entities.IndexingStatus;
 import org.orcid.persistence.jpa.entities.OrcidAware;
-import org.orcid.persistence.util.OrcidStringUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Value;

orcid-core/src/main/java/org/orcid/core/cli/CreateNewClientSecrets.java

@@ -18,8 +18,8 @@
 import org.orcid.core.manager.EncryptionManager;
 import org.orcid.persistence.jpa.entities.ClientDetailsEntity;
 import org.orcid.persistence.jpa.entities.ClientSecretEntity;
-import org.orcid.core.utils.DateUtils;
-import org.orcid.core.utils.NullUtils;
+import org.orcid.utils.DateUtils;
+import org.orcid.utils.NullUtils;
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 import org.springframework.transaction.TransactionStatus;

orcid-core/src/main/java/org/orcid/core/cli/DeleteWorkByIdentifier.java

@@ -13,7 +13,7 @@
 import org.kohsuke.args4j.Option;
 import org.orcid.persistence.dao.GenericDao;
 import org.orcid.persistence.jpa.entities.WorkEntity;
-import org.orcid.core.utils.NullUtils;
+import org.orcid.utils.NullUtils;
 import org.springframework.context.ApplicationContext;
 import org.springframework.context.support.ClassPathXmlApplicationContext;
 

orcid-core/src/main/java/org/orcid/core/cli/FindGroupsWithMixedVisibility.java

@@ -17,7 +17,7 @@
 import org.orcid.jaxb.model.v3.release.record.summary.WorkGroup;
 import org.orcid.jaxb.model.v3.release.record.summary.WorkSummary;
 import org.orcid.jaxb.model.v3.release.record.summary.Works;
-import org.orcid.core.utils.NullUtils;
+import org.orcid.utils.NullUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.context.ApplicationContext;

orcid-core/src/main/java/org/orcid/core/cli/ReindexProfiles.java

@@ -12,7 +12,7 @@
 import org.kohsuke.args4j.Option;
 import org.orcid.persistence.dao.ProfileDao;
 import org.orcid.persistence.jpa.entities.IndexingStatus;
-import org.orcid.core.utils.NullUtils;
+import org.orcid.utils.NullUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.context.ApplicationContext;

orcid-core/src/main/java/org/orcid/core/cli/anonymize/AnonymizeText.java

@@ -18,8 +18,8 @@
 import org.orcid.jaxb.model.v3.release.record.WorkContributors;
 import org.orcid.pojo.ajaxForm.ActivityExternalIdentifier;
 import org.orcid.pojo.ajaxForm.PojoUtil;
+import org.orcid.utils.OrcidStringUtils;
 import org.orcid.core.contributors.roles.works.WorkContributorRoleConverter;
-import org.orcid.core.utils.OrcidStringUtils;
 
 public class AnonymizeText {
 

orcid-core/src/main/java/org/orcid/core/cli/anonymize/WorkPojoFromCsv.java

@@ -12,7 +12,7 @@
 import org.orcid.jaxb.model.v3.release.record.ExternalIDs;
 import org.orcid.jaxb.model.v3.release.record.Work;
 import org.orcid.pojo.ajaxForm.PojoUtil;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 

orcid-core/src/main/java/org/orcid/core/common/manager/EmailDomainManager.java

@@ -10,7 +10,7 @@ public interface EmailDomainManager {
 
     boolean updateCategory(long id, EmailDomainEntity.DomainCategory category);
 
-    EmailDomainEntity findByEmailDoman(String emailDomain);
+    EmailDomainEntity findByEmailDomain(String emailDomain);
 
     List<EmailDomainEntity> findByCategory(EmailDomainEntity.DomainCategory category);
 

orcid-core/src/main/java/org/orcid/core/common/manager/impl/EmailDomainManagerImpl.java

@@ -48,11 +48,11 @@ public boolean updateCategory(long id, DomainCategory category) {
     }
 
     @Override
-    public EmailDomainEntity findByEmailDoman(String emailDomain) {
+    public EmailDomainEntity findByEmailDomain(String emailDomain) {
         if (emailDomain == null || emailDomain.isBlank()) {
             throw new IllegalArgumentException("Email Domain must not be empty");
         }
-        return emailDomainDaoReadOnly.findByEmailDoman(emailDomain);
+        return emailDomainDaoReadOnly.findByEmailDomain(emailDomain);
     }
 
     @Override
@@ -65,7 +65,7 @@ public List<EmailDomainEntity> findByCategory(DomainCategory category) {
 
     @Override
     public STATUS createOrUpdateEmailDomain(String emailDomain, String rorId) {
-        EmailDomainEntity existingEntity = emailDomainDaoReadOnly.findByEmailDoman(emailDomain);
+        EmailDomainEntity existingEntity = emailDomainDaoReadOnly.findByEmailDomain(emailDomain);
         if(existingEntity != null) {
             if(!rorId.equals(existingEntity.getRorId())) {
                 boolean updated = emailDomainDao.updateRorId(existingEntity.getId(), rorId);

orcid-core/src/main/java/org/orcid/core/locale/LocaleManagerImpl.java

@@ -11,8 +11,8 @@
 import org.orcid.core.manager.CountryManager;
 import org.orcid.jaxb.model.message.OrcidProfile;
 import org.orcid.persistence.jpa.entities.CountryIsoEntity;
+import org.orcid.utils.OrcidStringUtils;
 import org.orcid.core.utils.FunctionsOverCollections;
-import org.orcid.core.utils.OrcidStringUtils;
 import org.orcid.core.utils.UTF8Control;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.cache.annotation.Cacheable;

orcid-core/src/main/java/org/orcid/core/manager/impl/EncryptionManagerImpl.java

@@ -11,7 +11,7 @@
 import org.orcid.core.crypto.DesEncrypter;
 import org.orcid.core.manager.EncryptionManager;
 import org.orcid.pojo.ajaxForm.PojoUtil;
-import org.orcid.core.utils.OrcidStringUtils;
+import org.orcid.utils.OrcidStringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.InitializingBean;

orcid-core/src/main/java/org/orcid/core/manager/impl/GroupIdRecordManagerImpl.java

@@ -22,7 +22,7 @@
 import org.orcid.jaxb.model.groupid_v2.GroupIdRecord;
 import org.orcid.persistence.jpa.entities.GroupIdRecordEntity;
 import org.orcid.persistence.jpa.entities.SourceEntity;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Value;

orcid-core/src/main/java/org/orcid/core/manager/impl/OrcidSecurityManagerImpl.java

@@ -56,7 +56,7 @@
 import org.orcid.persistence.jpa.entities.ProfileEntity;
 import org.orcid.persistence.jpa.entities.SourceAwareEntity;
 import org.orcid.persistence.jpa.entities.SourceEntity;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.security.core.Authentication;
 import org.springframework.security.core.GrantedAuthority;

orcid-core/src/main/java/org/orcid/core/manager/impl/OrgManagerImpl.java

@@ -9,7 +9,6 @@
 import org.orcid.core.manager.OrgManager;
 import org.orcid.core.manager.SourceManager;
 import org.orcid.core.manager.read_only.ClientDetailsManagerReadOnly;
-import org.orcid.core.utils.OrcidStringUtils;
 import org.orcid.jaxb.model.common_v2.OrganizationHolder;
 import org.orcid.jaxb.model.message.Iso3166Country;
 import org.orcid.jaxb.model.message.Organization;
@@ -21,6 +20,7 @@
 import org.orcid.persistence.jpa.entities.OrgEntity;
 import org.orcid.persistence.jpa.entities.ProfileEntity;
 import org.orcid.persistence.jpa.entities.SourceEntity;
+import org.orcid.utils.OrcidStringUtils;
 
 import au.com.bytecode.opencsv.CSVWriter;
 

orcid-core/src/main/java/org/orcid/core/manager/read_only/impl/BiographyManagerReadOnlyImpl.java

@@ -7,7 +7,7 @@
 import org.orcid.jaxb.model.record_v2.Biography;
 import org.orcid.persistence.dao.BiographyDao;
 import org.orcid.persistence.jpa.entities.BiographyEntity;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

orcid-core/src/main/java/org/orcid/core/manager/read_only/impl/PeerReviewManagerReadOnlyImpl.java

@@ -51,7 +51,7 @@ public List<PeerReview> findPeerReviews(String orcid) {
     }
 
     /**
-     * Get the list of peer reivews that belongs to a user
+     * Get the list of peer reviews that belongs to a user
      * 
      * @param userOrcid
      * @param lastModified

orcid-core/src/main/java/org/orcid/core/manager/read_only/impl/PersonalDetailsManagerReadOnlyImpl.java

@@ -15,7 +15,7 @@
 import org.orcid.jaxb.model.record_v2.OtherName;
 import org.orcid.jaxb.model.record_v2.OtherNames;
 import org.orcid.jaxb.model.record_v2.PersonalDetails;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 
 /**
  * 

orcid-core/src/main/java/org/orcid/core/manager/read_only/impl/RecordManagerReadOnlyImpl.java

@@ -28,7 +28,7 @@
 import org.orcid.jaxb.model.record_v2.SubmissionDate;
 import org.orcid.persistence.jpa.entities.ProfileEntity;
 import org.orcid.pojo.ajaxForm.PojoUtil;
-import org.orcid.core.utils.DateUtils;
+import org.orcid.utils.DateUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;