Fix npe (#7026)

amontenegro · web-flow · commit de5c965ba61d · 2024-04-18T10:57:54.000-06:00
* Deactivated records should get 409 on GET requests

* Fix annoying NPE
diff --git a/orcid-core/src/main/java/org/orcid/pojo/DigestEmail.java b/orcid-core/src/main/java/org/orcid/pojo/DigestEmail.java
@@ -27,7 +27,7 @@ public void addNotification(Notification notification) {
             sourceId = source.retrieveSourcePath();
         }
 
-        if (source != null && source.getSourceName().getContent() != null &&
+        if (source != null && source.getSourceName() != null && source.getSourceName().getContent() != null &&
                 !sources.contains(source.getSourceName().getContent())) {
             sources.add(source.getSourceName().getContent());
         }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public void addNotification(Notification notification) {`
`27`	`27`	`sourceId = source.retrieveSourcePath();`
`28`	`28`	`}`
`29`	`29`
`30`		`- if (source != null && source.getSourceName().getContent() != null &&`
	`30`	`+ if (source != null && source.getSourceName() != null && source.getSourceName().getContent() != null &&`
`31`	`31`	`!sources.contains(source.getSourceName().getContent())) {`
`32`	`32`	`sources.add(source.getSourceName().getContent());`
`33`	`33`	`}`