add source name and or id to emails missing both

ORCID · Oct 30, 2024 · e07961a · e07961a
1 parent 6a39790
commit e07961a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/orcid-web/src/main/java/org/orcid/frontend/web/controllers/ManageProfileController.java b/orcid-web/src/main/java/org/orcid/frontend/web/controllers/ManageProfileController.java
@@ -536,7 +536,17 @@ public ModelAndView confirmDeactivateOrcidAccount(HttpServletRequest request, Ht
         if (Features.EMAIL_DOMAINS.isActive()) {
             emailDomains = profileEmailDomainManagerReadOnly.getEmailDomains(getCurrentUserOrcid());
         }
-        return org.orcid.pojo.ajaxForm.Emails.valueOf(v2Emails, emailDomains);
+        org.orcid.pojo.ajaxForm.Emails emails = org.orcid.pojo.ajaxForm.Emails.valueOf(v2Emails, emailDomains);
+        // Old emails are missing the source name and id -- assign the user as the source
+        for (org.orcid.pojo.ajaxForm.Email email: emails.getEmails()) {
+            if (email.getSource() == null && email.getSourceName() == null) {
+                String orcid = getCurrentUserOrcid();
+                String displayName = getPersonDetails(orcid, true).getDisplayName();
+                email.setSource(orcid);
+                email.setSourceName(displayName);
+            }
+        }
+        return emails;
     }
 
     @RequestMapping(value = "/emails.json", method = RequestMethod.POST)

diff --git a/orcid-web/src/main/java/org/orcid/frontend/web/controllers/PublicRecordController.java b/orcid-web/src/main/java/org/orcid/frontend/web/controllers/PublicRecordController.java
@@ -202,8 +202,16 @@ PublicRecord getRecord(String orcid) {
         if (Features.EMAIL_DOMAINS.isActive()) {
             emailDomains = profileEmailDomainManagerReadOnly.getPublicEmailDomains(orcid);
         }
-
-        publicRecord.setEmails(org.orcid.pojo.ajaxForm.Emails.valueOf(filteredEmails, emailDomains));
+
+        org.orcid.pojo.ajaxForm.Emails emails = org.orcid.pojo.ajaxForm.Emails.valueOf(filteredEmails, emailDomains);
+        // Old emails are missing the source name and id -- assign the user as the source
+        for (org.orcid.pojo.ajaxForm.Email email: emails.getEmails()) {
+            if (email.getSource() == null && email.getSourceName() == null) {
+                email.setSource(orcid);
+                email.setSourceName(publicRecord.getDisplayName());
+            }
+        }
+        publicRecord.setEmails(emails);
 
         // Fill external identifiers
         PersonExternalIdentifiers publicPersonExternalIdentifiers;