diff --git a/CHANGELOG.md b/CHANGELOG.md index 85229deb5..389967293 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,35 @@ +## v2.107.12 - 2024-11-15 + +[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.107.11...v2.107.12) + +## v2.107.11 - 2024-11-13 + +[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.107.10...v2.107.11) + +## v2.107.10 - 2024-11-13 + +[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.107.9...v2.107.10) + +- [#2396](https://github.com/ORCID/orcid-angular/pull/2396): 9497 resolve the issues integrators are having when embedding summaries into iframes +- [#2393](https://github.com/ORCID/orcid-angular/pull/2393): Bump rollup from 3.29.4 to 3.29.5 +- [#2395](https://github.com/ORCID/orcid-angular/pull/2395): scroll to top on email interstitial +- [#2394](https://github.com/ORCID/orcid-angular/pull/2394): convert to matrix format and bump all action versions for node version + +### Fix + +- bump linting action versions + +## 2.108.0 - 2024-11-13 + +[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.107.9...2.108.0) + +- [#2395](https://github.com/ORCID/orcid-angular/pull/2395): scroll to top on email interstitial +- [#2394](https://github.com/ORCID/orcid-angular/pull/2394): convert to matrix format and bump all action versions for node version + +### Fix + +- bump linting action versions + ## 2.107.10 - 2024-11-12 [Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.107.9...2.107.10) diff --git a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss index b1b65eadf..5c2863a67 100644 --- a/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss +++ b/src/app/cdk/trusted-summary/component/trusted-summary/trusted-summary.component.scss @@ -2,7 +2,6 @@ width: 100%; display: flex; justify-content: center; - height: 100vh; } main.stand-alone-mode { @@ -17,6 +16,7 @@ main.inside-iframe { align-content: start; grid-gap: 0; box-sizing: border-box; + height: 100vh; .panel-body { padding-top: 16px; diff --git a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.html b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.html index cd639f1d4..15b512002 100644 --- a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.html +++ b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.html @@ -132,6 +132,25 @@

+ + No verified email addresses found + +

+ You must have at least one verified email address in your ORCID account + to register for your Public API credentials. Manage your email addresses + in the + Emails and domains section of your ORCID record. +

+
+
warning diff --git a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.scss b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.scss index 119a7b114..0746ee38e 100644 --- a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.scss +++ b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.scss @@ -45,3 +45,14 @@ h2 { .mat-button-wrap-text { margin-bottom: 32px; } + +app-alert-message { + line-height: 21px; + margin-top: 16px; + a { + text-decoration: underline; + } + p { + margin-bottom: 0; + } +} diff --git a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.spec.ts b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.spec.ts index d89be9998..5830ed280 100644 --- a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.spec.ts +++ b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.spec.ts @@ -7,6 +7,8 @@ import { RecordService } from 'src/app/core/record/record.service' import { of } from 'rxjs' import { CUSTOM_ELEMENTS_SCHEMA } from '@angular/core' +import { MatLegacyDialog } from '@angular/material/legacy-dialog' +import { useAnimation } from '@angular/animations' describe('TermsOfUseComponent', () => { let component: TermsOfUseComponent @@ -19,6 +21,7 @@ describe('TermsOfUseComponent', () => { { provide: DeveloperToolsService, useValue: {} }, { provide: PlatformInfoService, useValue: {} }, { provide: RecordService, useValue: { getRecord: () => of() } }, + { provide: MatLegacyDialog, useValue: {} }, ], schemas: [CUSTOM_ELEMENTS_SCHEMA], }).compileComponents() diff --git a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.ts b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.ts index e0f049baa..0d14e464b 100644 --- a/src/app/developer-tools/components/terms-of-use/terms-of-use.component.ts +++ b/src/app/developer-tools/components/terms-of-use/terms-of-use.component.ts @@ -9,9 +9,11 @@ import { ViewChild, } from '@angular/core' import { MatLegacyCheckbox as MatCheckbox } from '@angular/material/legacy-checkbox' +import { MatLegacyDialog } from '@angular/material/legacy-dialog' import { Subject } from 'rxjs' import { takeUntil } from 'rxjs/operators' import { PlatformInfoService } from 'src/app/cdk/platform-info' +import { ModalEmailComponent } from 'src/app/cdk/side-bar/modals/modal-email/modal-email.component' import { DeveloperToolsService } from 'src/app/core/developer-tools/developer-tools.service' import { RecordService } from 'src/app/core/record/record.service' @@ -31,10 +33,12 @@ export class TermsOfUseComponent implements OnInit, OnDestroy { @Output() developerToolsEnable = new EventEmitter() $destroy = new Subject() emailAlreadyVerified: boolean + hasVerifiedEmailAddress: boolean constructor( private developerToolsService: DeveloperToolsService, private _record: RecordService, + private _dialog: MatLegacyDialog, private _changeDetectorRef: ChangeDetectorRef ) {} ngOnDestroy(): void { @@ -50,6 +54,9 @@ export class TermsOfUseComponent implements OnInit, OnDestroy { const primaryEmail = userRecord?.emails?.emails?.filter( (email) => email.primary )[0] + this.hasVerifiedEmailAddress = userRecord.emails.emails.some( + (email) => email.verified + ) if (primaryEmail?.verified) { this.emailAlreadyVerified = true this._changeDetectorRef.detectChanges() @@ -57,6 +64,17 @@ export class TermsOfUseComponent implements OnInit, OnDestroy { }) } + openEmailModal() { + return this._dialog + .open(ModalEmailComponent, { + width: '850px', + maxWidth: '99%', + // data: this.userRecord, + // ariaLabel: getAriaLabel(this.editModalComponent, this.type), + }) + .afterClosed() + } + registerForPublicApi() { this.dirty = true if (!this.checked) { diff --git a/src/app/developer-tools/developer-tools.module.ts b/src/app/developer-tools/developer-tools.module.ts index b4d50e3a0..81061d8d3 100644 --- a/src/app/developer-tools/developer-tools.module.ts +++ b/src/app/developer-tools/developer-tools.module.ts @@ -22,6 +22,7 @@ import { ModalModule } from '../cdk/modal/modal.module' import { A11yLinkModule } from '../cdk/a11y-link/a11y-link.module' import { TopBarVerificationEmailModule } from '../cdk/top-bar-verification-email/top-bar-verification-email.module' import { DeveloperToolsComponent } from './pages/developer-tools/developer-tools.component' +import { AlertMessageModule } from '../cdk/alert-message/alert-message.module' @NgModule({ declarations: [ @@ -49,6 +50,7 @@ import { DeveloperToolsComponent } from './pages/developer-tools/developer-tools ModalModule, A11yLinkModule, TopBarVerificationEmailModule, + AlertMessageModule, ], }) export class DeveloperToolsModule {} diff --git a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html index ace05d21e..03406c9f3 100644 --- a/src/app/developer-tools/pages/developer-tools/developer-tools.component.html +++ b/src/app/developer-tools/pages/developer-tools/developer-tools.component.html @@ -204,56 +204,47 @@

your integration users will experience an error.

-
-
- info -
-
- Please note -
    -
  • - - Only - HTTPS URIs - - are accepted in production - -
  • -
  • - Domains registered - MUST - exactly match the domains used, including - subdomains -
  • -
  • - Register all redirect URIs fully where possible. - This is the most secure option and what we recommend. For - more information about redirect URIs, please see - our - - redirect URI FAQ -
  • -
-
-
+ + Please note +
    +
  • + Only + HTTPS URIs + + are accepted in production + +
  • +
  • + Domains registered + MUST + exactly match the domains used, including + subdomains +
  • +
  • + Register all redirect URIs fully where possible. + This is the most secure option and what we recommend. For + more information about redirect URIs, please see + our + + redirect URI FAQ +
  • +
+
@@ -453,6 +444,27 @@

Redirect URIs must be unique

+ The ORCID Public API is free for non-commercial use by + individuals as stated in the + Public APIs Terms of Service. + By “non-commercial” we mean that you may not charge any re-use + fees for the Public API, and you may not make use of the Public + API in connection with any revenue-generating product or + service. + + + +

+ + +
+ + +
+ + + + diff --git a/yarn.lock b/yarn.lock index 54027b35c..24456a326 100644 --- a/yarn.lock +++ b/yarn.lock @@ -14291,9 +14291,9 @@ robots-parser@^2.0.1: integrity sha512-oO8f2SI04dJk3pbj2KOMJ4G6QfPAgqcGmrYGmansIcpRewIPT2ljWEt5I+ip6EgiyaLo+RXkkUWw74M25HDkMA== rollup@^3.25.2: - version "3.29.4" - resolved "https://registry.npmjs.org/rollup/-/rollup-3.29.4.tgz" - integrity sha512-oWzmBZwvYrU0iJHtDmhsm662rC15FRXmcjCk1xD771dFDx5jJ02ufAQQTn0etB2emNk4J9EZg/yWKpsn9BWGRw== + version "3.29.5" + resolved "https://registry.yarnpkg.com/rollup/-/rollup-3.29.5.tgz#8a2e477a758b520fb78daf04bca4c522c1da8a54" + integrity sha512-GVsDdsbJzzy4S/v3dqWPJ7EfvZJfCHiDqe80IyrF59LYuP+e6U1LJoUqeuqRbwAWoMNoXivMNeNAOf5E22VA1w== optionalDependencies: fsevents "~2.3.2"