Use Webform Share instead of Webform embed module as the latter throws error

[madsnorgaard]

Getting the following error when pressing the embed button for any webform with Webform Revision installed:
Error: Call to a member function get() on null i Drupal\webform_revisions\WebformRevisionsRequest->getCurrentWebform() (linje 171 af /opt/drupal/web/modules/contrib/config_entity_revisions/modules/webform_revisions/src/WebformRevisionsRequest.php)

I believe we should rather use the much more integrated Webform Share module.

Proposed fix:
Remove Webform Embed as a dependency for the os2forms module as include Webform Share instead.

Win:
Webform Share module is so much better :)

[madsnorgaard]

It would be great to have a discussion and transition towards this or a fix. Let me know when this might suite you.

[andriyun]

Hi all

Unfortunately, I don't have info on use cases where the webform embed module is used. So I can not say am I agree/disagree.

Webform embed module doesn't seem like under maintenance. https://www.drupal.org/project/webform_embed/issues/3235054
So if it makes sense, you can get the maintainer right and get the bug fixed.

Webform share module is part of the general Webform module https://git.drupalcode.org/project/webform/-/tree/6.1.x/modules
So it can be used right away
No code changes needed