From 292ad0497b111073b2725d87fe611570ff3af254 Mon Sep 17 00:00:00 2001 From: Pernille Thorsen Date: Wed, 8 Mar 2023 08:52:45 +0100 Subject: [PATCH] Codereview focus update Adding section with codereview tasks. --- README.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index efa0456..9877e7c 100644 --- a/README.md +++ b/README.md @@ -76,7 +76,7 @@ For new repositories it was decided to switch back to github, composer way to for branch names. -## Code review +## Code review proces New changes or bugfixes in existing codebase have to be added to repository through general [code review process](https://github.com/features/code-review/). To request a code review, use the following process: @@ -93,6 +93,13 @@ NOTE: There are preconditions that have to be met before accepting a pull reques - All discussion have to be resolved - Pull request should have green Travis CI build status. +##Code review tasks +Giving codereview to other developers code should cover +1. The use of [Code of conduct](docs#coc) +2. The following of the [Testing standards](docs#testing-and-ci) +3. That kode is handling successes and errors, can not end in loops and other logical +4. Other questions the developers might see. + ## Patching principles To patch a drupal composer project see: