Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing os2forms_forloeb as dependency #41

Open
andriyun opened this issue Jan 26, 2022 · 1 comment
Open

Missing os2forms_forloeb as dependency #41

andriyun opened this issue Jan 26, 2022 · 1 comment

Comments

@andriyun
Copy link
Contributor

Hi there
During the update process from OS2Forms to OS2Forms med forløb, I have found that os2forms_forloeb module is not a dependency for os2forms_forloeb_profile.

Besides, I see that in build-forloeb command this module activates in the end.

Shouldn'tos2forms_forloeb module be a dependency for os2forms_forloeb_profile?

@madsnorgaard
Copy link
Collaborator

Hi Andriy,

Does this line not require os2forms_forloeb module as a dependency?

"os2forms/os2forms_forloeb": "^2.0.0-rc",

We removed the profile as a dependency for the module as the dependency should go one way in this structure.

Let me know if you have any further thoughts on this.

Kindest regards, Mads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants