Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create branch protection rules for main #10

Open
janhalen opened this issue Jun 6, 2024 · 2 comments
Open

Create branch protection rules for main #10

janhalen opened this issue Jun 6, 2024 · 2 comments

Comments

@janhalen
Copy link
Contributor

janhalen commented Jun 6, 2024

Suggested branch protection rules

To avoid bothering devs with the PR flow for every small change, I suggest we describe all the features that are ordered by the Product Owner manully in "Epic" issues and create branches manually that has a strict naming convention not to have the issue number in the title.
This makes the Epic the "main" features and has the nice added benefit, that it is more human readable.

All other technical tasks that are needed to implement the ordered features, should follow the naming done by GitHub when creating a new branch directly from the issue form. (this could also be done manually in case this is forgotten by the dev).

Then we are set up for protecting the main branch with branchprotection that requires a PR.

Code review and tests offcource should still be done on all the technical issues, but it speeds up the flow a bit by not requiring a PR for merging all the technical issues into the "Epic" feature branch.

Later down the line, the project could look into automating the creating of "Epic" issues from an external project management system and even Automerging PRs after reviews (and other rules) are completed. This could be done into an "development" branch for extra safety, or even directly into the main branch if further speed is required in the development flow.

@kbp-di, lets dicuss this, when you have the time.

@janhalen
Copy link
Contributor Author

janhalen commented Jun 6, 2024

When the main code repo is created and populated, we can enable branch protection for main only so we can start getting a feel for the flow.

@janhalen
Copy link
Contributor Author

@kbp-di : Have you had the time to consider this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant