-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error with disabled days #7
Comments
Please @fgagneten can you give me the configuration you used for the disabled dates. I start working on it but have few time until Saturday. As for your other question, about using bower, we usually install projects as bower packages. This is the npm/bower world, but you can live without it, however it's interesting to learn and once you master it you don't have problems with it. Ionic sample app uses it too, if I am right. |
I see two bugs, after setting a "from/to" period that doesn't start at day 1 of a month and doesn't end at last day of month:
I need to update my comparison test project too, so that the day is kept when changing month, with original's project master which is ahead the last released version, since I installed the packaged version. |
…to test all possible values for from/to parameters.
This is my configuration:
```javascript
var ipObj1 = {
callback: callback,
inputDate: new Date(),
titleLabel: 'Seleccione una fecha',
setLabel: 'Cancelar',
todayLabel: 'Hoy',
closeLabel: 'Aceptar',
mondayFirst: true,
from: new Date(2016, 2, 1),
to: new Date(2017, 6, 15),
weeksList: ["D", "L", "M", "MI", "J", "V", "S"],
monthsList: ["Ene", "Feb", "Mar", "Abr", "May", "Jun", "Jul", "Ago", "Sep", "Oct", "Nov", "Dic"],
templateType: 'popup',
showTodayButton: false,
dateFormat: 'dd MMMM yyyy',
closeOnSelect: false
};
```
I set my from and to programatically, but please, see this video to
understand what happens:
https://streamable.com/0xic0
Faustino Gagneten.-
Edit by Xarkam: fusion.
|
@fgagneten I decide to freeze any development until next week. Please, standby |
…l project's master code to compare behaviors.
…d blocking for month, need to fix it for days.
Hi @fgagneten , glad to announce you that half of the bug is fixed, please download this release and enjoy: With any configuration, the day is correctly limited when navigation next/previous month. Now I work on fixing the available month selection in the month list. This is buggy on original project too. |
Glad to know that one part of the bug is fixed. Thanks a lot, specially @postb99 on helping us really fast! |
…se the months labels (the other option) but limit to the available months)
…d month names. Work in progress (month selection is empty).
… fix selection and adapt code elsewhere (for example currentMonth. A month is an object now, not just a string).
… : fix code when dropdown selection changes :-)
…ed date correctly change on month selection. Last thing to implement: adjust the selected day of target month to the available days of target month.
…available days of target month OK. Last thing to fix: the available months should change when the year changes (added a test case for this).
…ths by year. Need to add a refresh of month selection list.
… the check when year changes (going to an unavailable month in the other year did nothing instead of going to closest acceptable date).
From @fgagneten 2 days ago on original's project as comment in this thread: rajeshwarpatlolla#297
There is such a big error. Please, see this video to know what's going on with this fork:
https://streamable.com/0xic0
Using the original library this error not happening. Please, is too important to solve the problem when you limit the first and the last day in the calendar
The text was updated successfully, but these errors were encountered: