Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create contributing file #19

Open
wenzeslaus opened this issue Feb 14, 2025 · 7 comments
Open

Create contributing file #19

wenzeslaus opened this issue Feb 14, 2025 · 7 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@wenzeslaus
Copy link
Member

...and clarify how it works with computing, freezing, rendering and stuff.

@wenzeslaus wenzeslaus added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 14, 2025
@wenzeslaus
Copy link
Member Author

@cwhite911 Can you please help here?

@ecodiv
Copy link
Contributor

ecodiv commented Feb 15, 2025

@cwhite911 @wenzeslaus Just to check if I understand the procedure:

  1. A contributor creates a fork, modifies the source (the main branch), commits the changes and creates a pull request.
  2. A reviewer approves the pull request and merges it.
  3. The contributor or the reviewer (I would suggest the latter) renders the website locally, updates the gh-pages branch with the updated content, commits the changes, creates a pull request and merges the changes.
  4. The site is deployed automatically (?)

@petrasovaa
Copy link
Contributor

@cwhite911 @wenzeslaus Just to check if I understand the procedure:

  1. A contributor creates a fork, modifies the source (the main branch), commits the changes and creates a pull request.
    The same workflow as we use in main grass repo, the guide is already linked in README. A contributor creates a branch from their fork's main branch.

Ideally, at that point, their local page is built, so they commit the modifications in the freeze folder. That's what needs still to be clarified. See how this works. If they don't do that, a maintainer needs to do it and add it to the PR. Alternatively, we set the CI to do it, but my worry is this will trigger code execution (unless explicitly forbidden) and I don't think we want that. @cwhite911 any opinion on this?

  1. A reviewer approves the pull request and merges it.
  2. The contributor or the reviewer (I would suggest the latter) renders the website locally, updates the gh-pages branch with the updated content, commits the changes, creates a pull request and merges the changes.

this step needs to go before step 2

  1. The site is deployed automatically (?)

Yes

@echoix
Copy link
Member

echoix commented Feb 17, 2025

Alternatively, we set the CI to do it, but my worry is this will trigger code execution (unless explicitly forbidden) and I don't think we want that. @cwhite911 any opinion on this?

If CI commits changes, especially on forks, the new commit will not trigger workflow runs.

Does only the deployment job (once merged) is enough to ship the built site to be served?

@echoix
Copy link
Member

echoix commented Feb 17, 2025

The contributor or the reviewer (I would suggest the latter) renders the website locally, updates the gh-pages branch with the updated content, commits the changes, creates a pull request and merges the changes.

The gh-pages approach was deprecated/removed some time ago. It works with GitHub actions and an artifact.

https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#creating-a-custom-github-actions-workflow-to-publish-your-site

https://github.blog/changelog/2024-07-08-pages-legacy-worker-sunset/

@cwhite911
Copy link
Contributor

The current method works and is how Quarto has it documented, but I'll open a PR that uses the new method.

@echoix
Copy link
Member

echoix commented Feb 17, 2025

The current method works and is how Quarto has it documented, but I'll open a PR that uses the new method.

As long as the artifact to upload isn't too big, it goes well.
Under 1GB is fine. It needs to finish under 10 minutes. It cannot be bigger than 10GB. See
https://github.com/actions/upload-pages-artifact?tab=readme-ov-file#artifact-validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants