-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create contributing file #19
Comments
@cwhite911 Can you please help here? |
@cwhite911 @wenzeslaus Just to check if I understand the procedure:
|
Ideally, at that point, their local page is built, so they commit the modifications in the freeze folder. That's what needs still to be clarified. See how this works. If they don't do that, a maintainer needs to do it and add it to the PR. Alternatively, we set the CI to do it, but my worry is this will trigger code execution (unless explicitly forbidden) and I don't think we want that. @cwhite911 any opinion on this?
this step needs to go before step 2
Yes |
If CI commits changes, especially on forks, the new commit will not trigger workflow runs. Does only the deployment job (once merged) is enough to ship the built site to be served? |
The gh-pages approach was deprecated/removed some time ago. It works with GitHub actions and an artifact. https://github.blog/changelog/2024-07-08-pages-legacy-worker-sunset/ |
The current method works and is how Quarto has it documented, but I'll open a PR that uses the new method. |
As long as the artifact to upload isn't too big, it goes well. |
...and clarify how it works with computing, freezing, rendering and stuff.
The text was updated successfully, but these errors were encountered: