-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to build an OpenCV-free version of ClientKit and deps #77
Comments
I'd really like to see this change soon, this issue currently blocks integration into the Dolphin Emulator. It would also be a boon to game developers that won't have to ship OpenCV DLLs that they're likely not even using. |
Ideally we'd get rid of the OpenCV dependency in the ClientKit completely, we can put the image data in a common data type and have the developer decide what kind of image processing library to use. |
I see that OSVR already provides such a common data type, which means that OpenCV is used for nothing more than a wrapper in the ClientKit. Wrapping the data should be the responsibility of the application and not the ClientKit. |
Internally, there is basically only the bits in Common/ImagingComponent that use OpenCV - I think there's a type constant header and their buffer-freeing/allocating functions to handle appropriately-aligned buffers to enable. Shouldn't be too hard to make this optional at the build-system level and churn out libraries (with names modified to indicate no imaging support) without that code. Happy to review or help where needed. |
I don't really need OpenCV to be optional on the server-side, that would just complicate things. But if we can remove the dependency on the client-side as per PR #210 that would be perfect. |
merged! |
If building just the client portion (for instance, in a submodule), we should be able to exclude OpenCV support on request to reduce dependencies. Change would require:
noimaging
to the end or something) so they didn't accidentally get used in a situation where imaging support was requiredHAVE_IMAGING
define inspected by at least the imaging header.cc @Armada651
The text was updated successfully, but these errors were encountered: