Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of a few bugs #5

Closed
ThomasHeggarty opened this issue Jun 8, 2020 · 1 comment
Closed

Correction of a few bugs #5

ThomasHeggarty opened this issue Jun 8, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@ThomasHeggarty
Copy link
Contributor

ThomasHeggarty commented Jun 8, 2020

Hi all,
I've noticed a few small mistakes in the OSeMOSYS pyomo code, see my pull request for proposed corrections.
Thomas Heggarty
OSeMOSYS_2020_06_08.txt

@ThomasHeggarty
Copy link
Contributor Author

As shown in #6 , there are 6 corrections:

  • Line 231: The RETotalDemandOfTargetFuelAnnual variable doesn't appear in the OSeMOSYS documentation (see https://osemosys.readthedocs.io/en/latest/manual/Structure%20of%20OSeMOSYS.html ), however the pyomo code is missing the RETotalProductionOfTargetFuelAnnual variable, which is present in the documentation. My guess is that its name has changed in the problem description at some point, but wasn’t conveyed in the pyomo code. Note that, along with the storage constraints (see Contribution to OSeMOSYS_pyomo #1 and Update to storage equations #2 ), the pyomo code is also missing the "RE Production Target constraints", despite being in the official OSeMOSYS problem description. I do not know if this is deliberate; I have written the associated pyomo code and can upload it if need be.
  • Line 537: I think the same thing happened here: the variable name TotalAnnualCapacity must have been changed to TotalCapacityAnnual in the problem description at some point. The pyomo code was modified accordingly in most sections of the code, but not in the reserve margin equations, hence the proposed correction.
  • Line 538, 542 and 546: the final lines of each constraint is missing the term “model.” in front of each constraint name. If the term is missing, these constraints aren’t added to the model.
  • Line 541: The parameter ReserveMarginTagFuel is missing the sets on which it is defined. If missing, python throws an error.

@willu47 willu47 added the bug Something isn't working label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants