Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RE Production Target constraints #8

Closed
willu47 opened this issue Jun 10, 2020 · 3 comments · Fixed by #9
Closed

Missing RE Production Target constraints #8

willu47 opened this issue Jun 10, 2020 · 3 comments · Fixed by #9
Labels
bug Something isn't working enhancement New feature or request

Comments

@willu47
Copy link
Member

willu47 commented Jun 10, 2020

@ThomasHeggarty that, along with the storage constraints (see #1 and #2 ), the pyomo code is also missing the "RE Production Target constraints", despite being in the official OSeMOSYS problem description. I do not know if this is deliberate; @ThomasHeggarty has written the associated pyomo code and can upload it if need be.

@willu47 willu47 added bug Something isn't working enhancement New feature or request labels Jun 10, 2020
@willu47
Copy link
Member Author

willu47 commented Jun 10, 2020

@ThomasHeggarty - if you can submit a pull request with these constraints included, that would be great, thank you!

@ThomasHeggarty
Copy link
Contributor

Hi @willu47 - As requested, see #9
I have used the new code formatting you have proposed for constraints, which certainly enhances code readability. To improve it yet further, I would suggest removing the two carriage returns between a rule definition and its association to a constraint, as these are non dissociable concepts.

I will gladly perform this reformating if need be; I can also spend some time solving format inconsistencies (e.g. order in which sets appear in parameter, variable and constraint definitions).

@willu47
Copy link
Member Author

willu47 commented Jun 11, 2020

Hi @ThomasHeggarty - I used an automatic code linter called Black to reformat the code. It is possible to automate the formatting on every commit to git, and also to configure this - a lot easier than manually formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants