Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: otoole can not reach ReadStrategy._get_missing_input_dataframes(...) #221

Open
trevorb1 opened this issue Mar 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@trevorb1
Copy link
Member

trevorb1 commented Mar 30, 2024

Feature Request

The ._get_missing_input_dataframes(...) method is meant to align the input_data with the config file data. It will add empty dataframes if the user has not supplied data. However, the method ReadStrrategy._compare_read_to_expected(...) is often called before ._get_missing_input_dataframes(...) in the concrete classes. ._compare_read_to_expected(...) will raise a OtooleNameMismatchError if the input data and config data do not match (which is not entirely clear from the name OtooleNameMismatchError).

Is your feature related to a bug?

#169

Suggested Solution

I guess we could:

  1. Get rid of the ._compare_read_to_expected(...) method, and just raise a warning if the input data and config data dont match
  2. Change the error handling to a flag option (see issue [FEATURE]: Change checking of names to a flag option  #169)
  3. Get rid of the ._get_missing_input_dataframes(...) method and strictly enforce data consistency (which may be tedious for legacy models)

Additional Info

No response

@trevorb1 trevorb1 added the enhancement New feature or request label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant