Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bootstrap and make sure the whole site is using tailwind and there is no css #3416

Open
DonnieBLT opened this issue Feb 14, 2025 · 24 comments · May be fixed by #3685
Open

remove bootstrap and make sure the whole site is using tailwind and there is no css #3416

DonnieBLT opened this issue Feb 14, 2025 · 24 comments · May be fixed by #3685

Comments

@DonnieBLT
Copy link
Collaborator

No description provided.

@swaparup36
Copy link
Contributor

swaparup36 commented Feb 14, 2025

@DonnieBLT, Removing Bootstrap is okay. But, does only the internal CSS need to be removed and replaced with the tailwind, or does external CSS also? Like the files which are in "static/css", are they supposed to be removed too?

@iitzIrFan
Copy link

/assign

Copy link
Contributor

Hello @iitzIrFan! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request.

@iitzIrFan
Copy link

/unassign

@DonnieBLT
Copy link
Collaborator Author

Yes, if we can delete all the CSS files that will be good

@iitzIrFan
Copy link

@swaparup36 you can work this issue and sorry for assigning myself first there !

@swaparup36
Copy link
Contributor

@DonnieBLT can you assign me this one?

@iitzIrFan
Copy link

@swaparup36 just type /assign

Copy link
Contributor

You cannot be assigned to this issue because you are already assigned to the following issues without an open pull request: #3395. Please submit a pull request for these issues before getting assigned to a new one.

@AdityaSalagare
Copy link

is this issue open? I would like to take a crack at it as i am also exploring Tailwind @iitzIrFan

@devvrat-hans
Copy link

/assign

Copy link
Contributor

Hello @devvrat-hans! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request.

@DonnieBLT
Copy link
Collaborator Author

this would be to remove the remaining bootstrap styling and an additional step would be to add a pre-commit hook / lint that checks the code for any css styles there might be one or two exceptions but generally the whole codebase should be tailwind classes and no style tags

@devvrat-hans
Copy link

this would be to remove the remaining bootstrap styling and an additional step would be to add a pre-commit hook / lint that checks the code for any css styles there might be one or two exceptions but generally the whole codebase should be tailwind classes and no style tags

Thanks, @DonnieBLT! That sounds good. I'll start working on it.

@devvrat-hans
Copy link

I am respectfully unassigning myself from this pull request. The extensive scope of refactoring and the absence of detailed setup instructions, coupled with the 24 hour deadline, make it challenging for me to deliver a robust solution within the required timeframe.

@devvrat-hans
Copy link

/unassign

Copy link
Contributor

You have been unassigned from this issue. The issue is now available for others to work on.

@DonnieBLT
Copy link
Collaborator Author

Bootstrap was already removed. There are several files that have css remaining. It’s not much more work. There are plenty of setup instructions here https://github.com/OWASP-BLT/BLT/blob/main/Setup.md

@swaparup36
Copy link
Contributor

@DonnieBLT Sorry, I was not aware of this rule that I have to raise the PR within 24 hours. The task was to remove CSS and Bootstrap and use Tailwind CSS instead, to the entire website. There are so many files, so, it was taking time to complete this, I almost did most of it locally, Anyway, I am no longer assigned to this issue. I just wanted to clarify my side. It won't happen again from my side.

@DonnieBLT
Copy link
Collaborator Author

I made a view to see what files still have CSS on them. https://blt.owasp.org/template_list/?sort=has_style_tags

@SahilDhillon21
Copy link
Contributor

@DonnieBLT Sorry, I was not aware of this rule that I have to raise the PR within 24 hours. The task was to remove CSS and Bootstrap and use Tailwind CSS instead, to the entire website. There are so many files, so, it was taking time to complete this, I almost did most of it locally, Anyway, I am no longer assigned to this issue. I just wanted to clarify my side. It won't happen again from my side.

@swaparup36 Are you going to raise a PR or should I assign myself to this?

@SahilDhillon21
Copy link
Contributor

/assign

Copy link
Contributor

Hello @SahilDhillon21! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request.

@SahilDhillon21 SahilDhillon21 linked a pull request Feb 21, 2025 that will close this issue
Copy link
Contributor

⏰ This issue has been automatically unassigned due to 24 hours of inactivity. The issue is now available for anyone to work on again.

@github-actions github-actions bot removed the assigned label Feb 22, 2025
@DonnieBLT DonnieBLT added the $5 label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

6 participants