-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove bootstrap and make sure the whole site is using tailwind and there is no css #3416
Comments
@DonnieBLT, Removing Bootstrap is okay. But, does only the internal CSS need to be removed and replaced with the tailwind, or does external CSS also? Like the files which are in "static/css", are they supposed to be removed too? |
/assign |
Hello @iitzIrFan! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request. |
/unassign |
Yes, if we can delete all the CSS files that will be good |
@swaparup36 you can work this issue and sorry for assigning myself first there ! |
@DonnieBLT can you assign me this one? |
@swaparup36 just type /assign |
You cannot be assigned to this issue because you are already assigned to the following issues without an open pull request: #3395. Please submit a pull request for these issues before getting assigned to a new one. |
is this issue open? I would like to take a crack at it as i am also exploring Tailwind @iitzIrFan |
/assign |
Hello @devvrat-hans! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request. |
this would be to remove the remaining bootstrap styling and an additional step would be to add a pre-commit hook / lint that checks the code for any css styles there might be one or two exceptions but generally the whole codebase should be tailwind classes and no style tags |
Thanks, @DonnieBLT! That sounds good. I'll start working on it. |
I am respectfully unassigning myself from this pull request. The extensive scope of refactoring and the absence of detailed setup instructions, coupled with the 24 hour deadline, make it challenging for me to deliver a robust solution within the required timeframe. |
/unassign |
You have been unassigned from this issue. The issue is now available for others to work on. |
Bootstrap was already removed. There are several files that have css remaining. It’s not much more work. There are plenty of setup instructions here https://github.com/OWASP-BLT/BLT/blob/main/Setup.md |
@DonnieBLT Sorry, I was not aware of this rule that I have to raise the PR within 24 hours. The task was to remove CSS and Bootstrap and use Tailwind CSS instead, to the entire website. There are so many files, so, it was taking time to complete this, I almost did most of it locally, Anyway, I am no longer assigned to this issue. I just wanted to clarify my side. It won't happen again from my side. |
I made a view to see what files still have CSS on them. https://blt.owasp.org/template_list/?sort=has_style_tags |
@swaparup36 Are you going to raise a PR or should I assign myself to this? |
/assign |
Hello @SahilDhillon21! You've been assigned to OWASP-BLT/BLT issue #3416. You have 24 hours to complete a pull request. |
⏰ This issue has been automatically unassigned due to 24 hours of inactivity. The issue is now available for anyone to work on again. |
No description provided.
The text was updated successfully, but these errors were encountered: