Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Adblockers can cause Export Trades to fail #48

Open
ghettodev opened this issue Apr 5, 2018 · 3 comments
Open

Adblockers can cause Export Trades to fail #48

ghettodev opened this issue Apr 5, 2018 · 3 comments

Comments

@ghettodev
Copy link

Export Trades seems to be making XHR requests to https://oasisdex.github.io/oasis-dex-script/maker-otc-*.trades.json which fail when uBlock is active. This causes the UI to replace the Generate Report button with a spinner which never expires.

screenshot from 2018-04-04 21-03-24

@peculiarity
Copy link

@ghettodev can you suggest any idea how to solve this. In general the application works fine so it's not an issue of the application but the 3rd parity tool you are using.

@peculiarity
Copy link

@luke7211 Opinion?

@ghettodev
Copy link
Author

It's a philosophical issue I think. If you want to accept that adblockers are a fact of life, then probably make sure the requests are all pointing at the originating domain. If you can't code around it then there should be an alert warning people to turn it off or some kind of feedback other than an unending spinner.

I'm inclined to believe that a higher than average number of people who are into crypto are security conscious and have one or more privacy extensions running.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants