Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty summary tags to all objects, properties and methods. #135

Closed
tacosontitan opened this issue Aug 15, 2021 · 6 comments
Closed

Add empty summary tags to all objects, properties and methods. #135

tacosontitan opened this issue Aug 15, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@tacosontitan
Copy link

After reviewing a large chunk of files, I've noticed that summary tags are not present to enable natural understanding and reduce the likelihood of open interpretation when working with objects, properties or methods. I would like to propose that summary tags be added to:

  • User-Defined Types
  • Properties
  • Methods

Additionally, if exceptions can be thrown from within methods or the get/set methods of properties then the appropriate exception tags should also be added.


At a minimum, these tags should be present, even if empty to consider this issue completed. This is because having the tags present will help encourage developers that have an understanding of the area they're working in, to add documentation for intellisense to pick up on. It also enables the ability to generate living documentation for the API project.

@Craftplacer
Copy link
Collaborator

Craftplacer commented Aug 16, 2021

I would suggest, don't over-document the code base. There are cases (applicable in any C# project) where the method name and class context are more valuable and self-explanatory than a <summary>Gets a player</summary>.

I don't agree on the "add empty summaries everywhere" as they're as useless as not adding a summary at all, in my opinion.

I would rephrase this issue as "Add missing code documentation" (XMLdocs).

@Craftplacer Craftplacer added the enhancement New feature or request label Aug 16, 2021
@Craftplacer
Copy link
Collaborator

Also at further investigation, this issue seems a duplicate of #79.

@Naamloos any interest of merging/extending the scope of #79 to the entire codebase?

@Naamloos
Copy link
Member

Naamloos commented Aug 16, 2021

Suresies, big yes.

Documentation and comments are important, and obsidian is severely lacking in it.
I'd say, add summaries to everything where it'd make sense.

@Craftplacer
Copy link
Collaborator

Should we merge this issue into #79 and close it then?

@tacosontitan
Copy link
Author

Should we merge this issue into #79 and close it then?

Ah, didn't see that in my searches; I'd concur with the merge and closure.

@tacosontitan
Copy link
Author

Oh, I forgot that I can close it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants