Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using give verb, Ghosts show up as an option to give item to. #275

Open
5 tasks done
RadiantFlash7 opened this issue Feb 21, 2021 · 1 comment
Open
5 tasks done
Labels
Bug Something isn't working as intended. 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 ⚠️ Severity: S-5 Trivial Small issue that is almost negligible. (Typos for example)

Comments

@RadiantFlash7
Copy link
Collaborator

RadiantFlash7 commented Feb 21, 2021

Description of issue

When using give verb, Ghosts show up as an option to give item to.

Difference between expected and actual behavior

Should only give living players

Steps to reproduce

Give an item to someone with a ghost adjacent to you.
See ghost name appear in list of people to give obj to.

Specific information for locating

N/A

Length of time in which bug has been known to occur

For months atleast.

Client version, Server revision & Game ID

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of the issue being looked at sooner.

  • Issue could be reproduced at least once
  • Issue could be reproduced by different players
  • Issue could be reproduced in multiple rounds
  • Issue happened in a recent (less than 7 days ago) round
  • Couldn't find an existing issue about this
@zackerycodestoo zackerycodestoo added Bug Something isn't working as intended. ⚠️ Severity: S-5 Trivial Small issue that is almost negligible. (Typos for example) 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 labels Feb 28, 2021
@zackerycodestoo
Copy link
Contributor

When investigating give code code/modules/mob/living/carbon/give.dm, I notice that it only targets /mob/living and also has a sanity check for if they're not /mob/living. My first thought is that either ghosts are considered under /mob/living (they are /mob/observer/ghost or we have overriding code somewhere that I can't find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended. 👥 Impact: I-5 Minimal (How many users is it expected to affect?) 0 - 1 ⚠️ Severity: S-5 Trivial Small issue that is almost negligible. (Typos for example)
Projects
None yet
Development

No branches or pull requests

2 participants