Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set the coefficient of restitution for particles #232

Open
ali-ramadhan opened this issue Nov 12, 2024 · 2 comments
Open

Ability to set the coefficient of restitution for particles #232

ali-ramadhan opened this issue Nov 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ali-ramadhan
Copy link
Collaborator

@almacarolina and I noticed that the coefficient of restitution for Lagrangian particles is hard-coded to 1.0 here:

advect_particles_kernel!(particles, 1.0, model.grid, Δt, total_velocities(model))

It would be nice if we could change it.

Happy to open a PR to add the option. I also see in #231 that the particles module might be moved out to Oceananigans though.

@ali-ramadhan ali-ramadhan added the enhancement New feature or request label Nov 12, 2024
@jagoosw
Copy link
Collaborator

jagoosw commented Nov 13, 2024

Yeah, that would be great!

I'm not sure how soon I'm likely to have time to make those changes and I think it might take a while to combine the particles here with the particles in Oceananigans since they've diverged quite a lot.

Also, we might need to make some changes following Simones PR if that bug also persists here.

@ali-ramadhan
Copy link
Collaborator Author

I ended up using advection = nothing so restitution = 1.0 is fine for now! And the main issue turned out to be CliMA/Oceananigans.jl#3917 anyways.

But if I end up needing to change restitution for biogeochemical particles I'm happy to try and open a PR. And if #231 happens then maybe this issue gets closed for free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants