You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure how soon I'm likely to have time to make those changes and I think it might take a while to combine the particles here with the particles in Oceananigans since they've diverged quite a lot.
Also, we might need to make some changes following Simones PR if that bug also persists here.
I ended up using advection = nothing so restitution = 1.0 is fine for now! And the main issue turned out to be CliMA/Oceananigans.jl#3917 anyways.
But if I end up needing to change restitution for biogeochemical particles I'm happy to try and open a PR. And if #231 happens then maybe this issue gets closed for free.
@almacarolina and I noticed that the coefficient of restitution for Lagrangian particles is hard-coded to
1.0
here:OceanBioME.jl/src/Particles/advection.jl
Line 24 in 3a01fc1
It would be nice if we could change it.
Happy to open a PR to add the option. I also see in #231 that the particles module might be moved out to Oceananigans though.
The text was updated successfully, but these errors were encountered: