You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm wondering if there's a cleaner solution here. Maybe a simulation callback? It's more work on the user to add the callback, but then there won't be a need for type piracy and to maintain separate time_step! functions.
I'm not sure if we can use hydrostatic RK3 time-stepping (CliMA/Oceananigans.jl#3930) with OceanBioME.jl because of this, but it looks like it's just isolated to using the sediment models?
The text was updated successfully, but these errors were encountered:
I noticed that https://github.com/OceanBioME/OceanBioME.jl/blob/main/src/Models/Sediments/coupled_timesteppers.jl uses type piracy to couple a sediment model with an Oceananigans model for time stepping.
I'm wondering if there's a cleaner solution here. Maybe a simulation callback? It's more work on the user to add the callback, but then there won't be a need for type piracy and to maintain separate
time_step!
functions.I'm not sure if we can use hydrostatic RK3 time-stepping (CliMA/Oceananigans.jl#3930) with OceanBioME.jl because of this, but it looks like it's just isolated to using the sediment models?
The text was updated successfully, but these errors were encountered: