Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sediment models will not work with hydrostatic RK3 time stepping #234

Open
ali-ramadhan opened this issue Nov 26, 2024 · 2 comments
Open

Comments

@ali-ramadhan
Copy link
Collaborator

ali-ramadhan commented Nov 26, 2024

I noticed that https://github.com/OceanBioME/OceanBioME.jl/blob/main/src/Models/Sediments/coupled_timesteppers.jl uses type piracy to couple a sediment model with an Oceananigans model for time stepping.

I'm wondering if there's a cleaner solution here. Maybe a simulation callback? It's more work on the user to add the callback, but then there won't be a need for type piracy and to maintain separate time_step! functions.

I'm not sure if we can use hydrostatic RK3 time-stepping (CliMA/Oceananigans.jl#3930) with OceanBioME.jl because of this, but it looks like it's just isolated to using the sediment models?

@glwagner
Copy link
Collaborator

yikes!

@jagoosw
Copy link
Collaborator

jagoosw commented Nov 27, 2024

Sediment time-stepping definitely needs to be overhauled!

We could probably do it in update_biogeochemical_state! like how particles are stepped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants