Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrate_pitot: cal_time_range is not being used #44

Open
dcherian opened this issue Mar 28, 2019 · 4 comments
Open

calibrate_pitot: cal_time_range is not being used #44

dcherian opened this issue Mar 28, 2019 · 4 comments

Comments

@dcherian
Copy link
Member

Hey it looks like cal_time_range is not used anymore? But that variable still exists. I'm getting merge conflicts so wondering why...

@dcherian
Copy link
Member Author

Similarly, looks like the default pitot speed estimate is 30s instead of 10min? Is this intentional?

@jbecherer
Copy link
Collaborator

your are right cal_range is not used anymore... there is no reason to keep it I guess...

the 30 sec, was me beeing lacy and not wanting to change it anytime I pull a fresh version :)
because for my deployments it is the best, but we can change it back... no objections.

@dcherian
Copy link
Member Author

the 30 sec, was me beeing lacy and not wanting to change it anytime I pull a fresh version :)

I've been dealing with this by having a branch that's particular to each "experiment" for experiment-specific default settings. And then I have instrument specific branches.

E.g. "master -> rama -> rama13-526" with each branch building on top of each other. It makes things complicated but it's relatively easy to ensure that all RAMA chipods have the same set of defaults.

@jbecherer
Copy link
Collaborator

That's smart..
I kind of solved it by not doing the processing locally, but with my mooring builder routines and the
database. But I am not super consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants